Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.13.z] Fix discovery rule test #14159

Merged
merged 1 commit into from
Feb 21, 2024
Merged

[6.13.z] Fix discovery rule test #14159

merged 1 commit into from
Feb 21, 2024

Conversation

shubhamsg199
Copy link
Contributor

Problem Statement

test_positive_end_to_end_crud is failing during creation of discoveryrule due to not returning the hostgroup required from the fixture.

Solution

Fix the module_hostgroup fixture to yield hostgroup as it was missing.

@shubhamsg199 shubhamsg199 added Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 labels Feb 21, 2024
@shubhamsg199 shubhamsg199 self-assigned this Feb 21, 2024
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_discoveryrule.py

Gauravtalreja1
Gauravtalreja1 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, We missed this in @omkarkhatavkar PR #13066

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5816
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_discoveryrule.py
Test Result : ================== 4 passed, 82 warnings in 896.81s (0:14:56) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 21, 2024
@jameerpathan111 jameerpathan111 merged commit 09ea172 into SatelliteQE:6.13.z Feb 21, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@shubhamsg199 shubhamsg199

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shubhamsg199 @Satellite-QE @jameerpathan111 @Gauravtalreja1