Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test steps, refresh uploaded manifest file #14195

Merged
merged 1 commit into from
Feb 28, 2024
Merged

add test steps, refresh uploaded manifest file #14195

merged 1 commit into from
Feb 28, 2024

Conversation

vijaysawant
Copy link
Contributor

@vijaysawant vijaysawant commented Feb 27, 2024 •
edited
Loading

Problem Statement

As per PX recommendation need to add steps and update automation coverage around the test.
Jira-23358

Solution

  • Add test steps in test case
  • Add additional assersions at the end of test

Related Issues

N/A

@vijaysawant vijaysawant added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Feb 27, 2024
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py -k test_missing_content_id

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5854
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_repository.py -k test_missing_content_id
Test Result : ========== 1 passed, 165 deselected, 11 warnings in 735.28s (0:12:15) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 27, 2024
@vijaysawant vijaysawant force-pushed the 23358-update-api-repository branch from f650f41 to fc2eaa9 Compare February 27, 2024 09:23
@vsedmik
Copy link
Contributor

vsedmik commented Feb 27, 2024 •
edited
Loading

CI/CQ failure seems unrelated to this PR, rather related to #13211 @pondrejk

test_positive_eol_banner_e2e:38
-------------------------------

* Unexpected tokens:
  Caselevel: Acceptance
  Testtype: Functional
  Upstream: No

@vijaysawant vijaysawant marked this pull request as ready for review February 27, 2024 09:42
@vijaysawant vijaysawant requested a review from a team as a code owner February 27, 2024 09:42
@vijaysawant vijaysawant force-pushed the 23358-update-api-repository branch from fc2eaa9 to 1d8c75c Compare February 27, 2024 09:53
ogajduse
ogajduse approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, but I, as a reviewer, would like to have more context about the change and what PX requests. That could be achieved by referencing a Jira issue in the PR description.

One minor comment left.

tests/foreman/api/test_repository.py Outdated Show resolved Hide resolved
shweta83
shweta83 requested changes Feb 27, 2024
View reviewed changes
tests/foreman/api/test_repository.py Outdated Show resolved Hide resolved
@vijaysawant vijaysawant force-pushed the 23358-update-api-repository branch from 1d8c75c to f6dca10 Compare February 27, 2024 10:24
Gauravtalreja1
Gauravtalreja1 reviewed Feb 27, 2024
View reviewed changes
tests/foreman/api/test_repository.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_eol_banner.py Outdated Show resolved Hide resolved
tests/foreman/api/test_repository.py Outdated Show resolved Hide resolved
@vijaysawant vijaysawant force-pushed the 23358-update-api-repository branch 3 times, most recently from 08d3e0d to 7db6ab0 Compare February 28, 2024 12:00
@vijaysawant vijaysawant marked this pull request as draft February 28, 2024 12:24
@vijaysawant vijaysawant force-pushed the 23358-update-api-repository branch from 7db6ab0 to fba7206 Compare February 28, 2024 12:37
@vijaysawant vijaysawant force-pushed the 23358-update-api-repository branch from fba7206 to 69589fb Compare February 28, 2024 12:40
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py -k test_missing_content_id

@vijaysawant vijaysawant removed 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Feb 28, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5880
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_repository.py -k test_missing_content_id --external-logging
Test Result : ========== 1 passed, 165 deselected, 11 warnings in 708.47s (0:11:48) ==========

@vijaysawant vijaysawant mentioned this pull request Feb 28, 2024
Merged
@vijaysawant vijaysawant marked this pull request as ready for review February 28, 2024 13:14
@vijaysawant vijaysawant requested a review from vsedmik February 28, 2024 13:23
@vsedmik vsedmik merged commit e94158a into SatelliteQE:master Feb 28, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 28, 2024
@vijaysawant @web-flow
add test steps, refresh uploaded manifest file (#14195)
2e603cc 
(cherry picked from commit e94158a)
This was referenced Feb 28, 2024
Merged
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@vijaysawant @shweta83
add test steps, refresh uploaded manifest file (SatelliteQE#14195)
8a2001f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 left review comments

@shweta83 shweta83 shweta83 requested changes

@vsedmik vsedmik vsedmik approved these changes

@ogajduse ogajduse ogajduse approved these changes

Assignees

@vijaysawant vijaysawant

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vijaysawant @Satellite-QE @vsedmik @ogajduse @Gauravtalreja1 @shweta83 @sambible @ColeHiggins2 @damoore044