Fix pytest deprecation warning #14205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying a mark to a fixture function never had any effect but is a common user error. see: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function
dosas
force-pushed
the
fix/pytest-deprecation-warnings
branch
from
14a5ab9 to
8898d4f
Compare
|
@dosas Thanks for raising the PR. Since its a warning now and errors in future versions, we will have to address this sooner. The appropriate solution I feel here is to use those markers directly on tests/test_classes/test_modules. We shall get back to on this soon!! |
lhellebr
approved these changes
Mar 4, 2024
|
Maybe there should be another PR putting those marks to the appropriate location but this one is good as it is, removing something that has no effect. |
Gauravtalreja1
added
CherryPick
|
@lhellebr Even I dont see any changes needed from PR diff that holds this PR from merging. But still need to assess once with non-diff code if the removals has any indirect impact! I shall have that checked by EOD today! |
jyejare
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Confirming that removing the markers custom or inbuilt does not have any impact as they were not really being used by tests or any inhouse pytest plugins.
@dosas Did you try to cover all such occurrences throughout robottelo fixtures? or would you like us to be completing the effort ?
|
I ran Without any errors, so all occurrences should be covered |
jyejare
approved these changes
Mar 7, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Fix pytest deprecation warning: Applying a mark to a fixture function never had any effect but is a common user error. see: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function (cherry picked from commit 215ddea)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Fix pytest deprecation warning: Applying a mark to a fixture function never had any effect but is a common user error. see: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function (cherry picked from commit 215ddea)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Fix pytest deprecation warning: Applying a mark to a fixture function never had any effect but is a common user error. see: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function (cherry picked from commit 215ddea)
This was referenced Mar 7, 2024
Gauravtalreja1
pushed a commit
that referenced
this pull request
Mar 7, 2024
Fix pytest deprecation warning (#14205) Fix pytest deprecation warning: Applying a mark to a fixture function never had any effect but is a common user error. see: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function (cherry picked from commit 215ddea) Co-authored-by: dosas <[email protected]>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Mar 7, 2024
Fix pytest deprecation warning (#14205) Fix pytest deprecation warning: Applying a mark to a fixture function never had any effect but is a common user error. see: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function (cherry picked from commit 215ddea) Co-authored-by: dosas <[email protected]>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Mar 7, 2024
Fix pytest deprecation warning (#14205) Fix pytest deprecation warning: Applying a mark to a fixture function never had any effect but is a common user error. see: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function (cherry picked from commit 215ddea) Co-authored-by: dosas <[email protected]>
shweta83
pushed a commit
to shweta83/robottelo
that referenced
this pull request
Apr 10, 2024
Fix pytest deprecation warning: Applying a mark to a fixture function never had any effect but is a common user error. see: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying a mark to a fixture function never had any effect but is a common user error.
see: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function