Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip repos_collection fixture to SCA #14217

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Feb 28, 2024

Problem Statement

As 6.16 is SCA-only we need to flip from entitlement to SCA mode. This fixture is still using entitlement, breaking all tests that use it in setup.

Solution

Flip it to SCA.

@vsedmik vsedmik added Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Feb 28, 2024
@vsedmik vsedmik self-assigned this Feb 28, 2024
@vsedmik vsedmik requested a review from a team as a code owner February 28, 2024 20:23
@sambible
Copy link
Contributor

You beat me to this change, haha!

@shweta83
Copy link
Contributor

@vsedmik This change can be done for 6.15.z as well. Wdyt?

@vsedmik
Copy link
Contributor Author

vsedmik commented Feb 29, 2024

@vsedmik This change can be done for 6.15.z as well. Wdyt?

@shweta83 For 6.15 I would keep the entitlement mode since there are still tests which use this fixture and test subscription-related actions and fields (like sub status, auto-attach, etc). For 6.16 it's a must however and those tests must be converted anyway for 6.16.

@shweta83
Copy link
Contributor

@vsedmik This change can be done for 6.15.z as well. Wdyt?

@shweta83 For 6.15 I would keep the entitlement mode since there are still tests which use this fixture and test subscription-related actions and fields (like sub status, auto-attach, etc). For 6.16 it's a must however and those tests must be converted anyway for 6.16.

Ok. I am good with this.

Copy link
Contributor

@shweta83 shweta83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@vsedmik vsedmik merged commit 44bbaf7 into SatelliteQE:master Feb 29, 2024
9 checks passed
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants