Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Fix server_config in subscription test #14235

Merged
merged 1 commit into from
Mar 1, 2024
Merged

[6.15.z] Fix server_config in subscription test #14235

merged 1 commit into from
Mar 1, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14226

Problem Statement

During z-stream sign-off I noticed that api/test_subscription.py/test_positive_delete_manifest_as_another_user is failing with

E   TypeError: Subscription.init() got multiple values for argument 'server_config'

since this entities refactor.

Solution

Pass the server_config as named parameter.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py -k delete_manifest_as_another_user

@Satellite-QE Satellite-QE requested a review from a team as a code owner March 1, 2024 10:36
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Mar 1, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py -k delete_manifest_as_another_user

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Mar 1, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 5913
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_subscription.py -k delete_manifest_as_another_user --external-logging
Test Result : ========== 1 passed, 17 deselected, 11 warnings in 710.99s (0:11:50) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 1, 2024
@Satellite-QE Satellite-QE merged commit 0c35844 into 6.15.z Mar 1, 2024
15 of 16 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.15.z-3ebc7c8c0c8b19b1945e375f0ae219b3d175bb25 branch March 1, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vsedmik vsedmik

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @vsedmik