Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hosts: run 'Manage columns' RFE test also for non-admin user #14247

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Hosts: run 'Manage columns' RFE test also for non-admin user #14247

merged 1 commit into from
Mar 11, 2024

Conversation

pnovotny
Copy link
Contributor

@pnovotny pnovotny commented Mar 4, 2024

hosts: run test_positive_manage_table_columns also with non-admin user

The test for hosts 'Manage Columns' feature now runs also for a non-admin user.

Resolves this customer BZ: https://bugzilla.redhat.com/2212499

@pnovotny pnovotny added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 4, 2024
@pnovotny pnovotny self-assigned this Mar 4, 2024
@pnovotny pnovotny requested review from pondrejk, lhellebr and a team March 4, 2024 13:08
@pnovotny
Copy link
Contributor Author

pnovotny commented Mar 4, 2024

trigger: test-robottelo
pytest: -k test_positive_manage_table_columns tests/foreman/ui/test_host.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5926
Build Status: UNSTABLE
PRT Comment: pytest -k test_positive_manage_table_columns tests/foreman/ui/test_host.py --external-logging
Test Result : ====== 1 passed, 40 deselected, 32 warnings, 1 error in 822.13s (0:13:42) ======

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 4, 2024
@pnovotny pnovotny force-pushed the selectable-columns-add-user branch from ab7cf5a to c9c59ae Compare March 6, 2024 11:29
@pnovotny
Copy link
Contributor Author

pnovotny commented Mar 6, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_positive_manage_table_columns or test_positive_host_details_read_templates'

@pnovotny pnovotny marked this pull request as ready for review March 6, 2024 12:17
@pnovotny pnovotny requested a review from a team as a code owner March 6, 2024 12:17
@pnovotny
Copy link
Contributor Author

pnovotny commented Mar 6, 2024

Actually PRT has passed:

 "pytest_result": "========== 3 passed, 39 deselected, 64 warnings in 912.71s (0:15:12) ===========",
11:56:52                                  "build_status": "SUCCESS"

It is the test result displatch event that failed the job.

Also the Code Quality failure is a known issue being worked upon here: JacobCallahan/ssh2-python#1

@pnovotny pnovotny added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Mar 6, 2024
@pnovotny
Copy link
Contributor Author

pnovotny commented Mar 7, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py::test_positive_manage_table_columns tests/foreman/ui/test_host.py::test_positive_host_details_read_templates

@pnovotny pnovotny force-pushed the selectable-columns-add-user branch from c9c59ae to 219861f Compare March 7, 2024 10:26
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5975
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_host.py::test_positive_manage_table_columns tests/foreman/ui/test_host.py::test_positive_host_details_read_templates --external-logging
Test Result : ================== 3 passed, 65 warnings in 899.85s (0:14:59) ==================

pondrejk
pondrejk reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@pondrejk pondrejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pnovotny please add 2212499 to the docstring on the test

@pnovotny
hosts: run test_positive_manage_table_columns also with non-admin user
402a8ba 
The test for hosts 'Manage Columns' feature now runs also for a non-admin user.

SAT-18169
https://bugzilla.redhat.com/2212499

Related changes:

`current_sat_org` and `current_sat_location` fixtures now return
the API object instead of the name to align with other similar fixtures
in taxonomy.py
@pnovotny pnovotny force-pushed the selectable-columns-add-user branch from 219861f to 402a8ba Compare March 11, 2024 09:40
@pondrejk pondrejk merged commit 4f213b3 into SatelliteQE:master Mar 11, 2024
6 of 7 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
@pnovotny @web-flow
Hosts: run 'Manage columns' RFE test also for non-admin user (#14247)
a56fbd8 
hosts: run test_positive_manage_table_columns also with non-admin user

The test for hosts 'Manage Columns' feature now runs also for a non-admin user.

SAT-18169
https://bugzilla.redhat.com/2212499

Related changes:

`current_sat_org` and `current_sat_location` fixtures now return
the API object instead of the name to align with other similar fixtures
in taxonomy.py

(cherry picked from commit 4f213b3)
@Satellite-QE Satellite-QE mentioned this pull request Mar 11, 2024
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@pnovotny @shweta83
Hosts: run 'Manage columns' RFE test also for non-admin user (Satelli…
e0ccef1 
…teQE#14247)

hosts: run test_positive_manage_table_columns also with non-admin user

The test for hosts 'Manage Columns' feature now runs also for a non-admin user.

SAT-18169
https://bugzilla.redhat.com/2212499

Related changes:

`current_sat_org` and `current_sat_location` fixtures now return
the API object instead of the name to align with other similar fixtures
in taxonomy.py
pnovotny added a commit to pnovotny/robottelo that referenced this pull request Apr 29, 2024
@pnovotny
host edit: test correct page redirection (SatelliteQE#14844)
4b498ff 
hosts: test correct page redirect after host edit

Component evaluation - SAT-21625
https://bugzilla.redhat.com/2166303

Check that after editing a host without making any changes(*),
the page is correctly redirected to the host details page.

(*) Making or not making any changes in the edit dialog
actually does not matter.

(cherry picked from commit de93ea2)

+ Backported changes from SatelliteQE#14247
for fixtures `current_sat_location` & `current_sat_org`.
pnovotny added a commit that referenced this pull request Apr 29, 2024
@pnovotny
hosts: test correct page redirect after host edit
9ae5a55 
Component evaluation - SAT-21625
https://bugzilla.redhat.com/2166303

Check that after editing a host without making any changes(*),
the page is correctly redirected to the host details page.

(*) Making or not making any changes in the edit dialog
actually does not matter.

(cherry picked from commit de93ea2)

+ Backported changes from #14247
for fixtures `current_sat_location` & `current_sat_org`.
pnovotny added a commit to pnovotny/robottelo that referenced this pull request Apr 30, 2024
@pnovotny
hosts: test correct page redirect after host edit
2ea2dee 
Component evaluation - SAT-21625
https://bugzilla.redhat.com/2166303

Check that after editing a host without making any changes(*),
the page is correctly redirected to the host details page.

(*) Making or not making any changes in the edit dialog
actually does not matter.

(cherry picked from commit de93ea2)

+ Backported changes from SatelliteQE#14247
for fixtures `current_sat_location` & `current_sat_org`.
@pnovotny pnovotny deleted the selectable-columns-add-user branch April 30, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synkd synkd synkd approved these changes

@pondrejk pondrejk pondrejk approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@pnovotny pnovotny

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pnovotny @Satellite-QE @lhellebr @pondrejk @synkd