Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Fail curl command registration #14266

Merged
merged 1 commit into from
Mar 5, 2024
Merged

[6.15.z] Fail curl command registration #14266

merged 1 commit into from
Mar 5, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14069

Problem Statement

Customer was trying to register client using global registration template and while executing curl command the client was registered but it failed at one point and the echo $? showed exit status as 0.

Solution

Giving status code 0 if passed else 1

Related Issues

@amolpati30 @web-flow
Fail curl command registration (#14069)
e4b194c 
* giving status code as expected for failure test

* giving status code as expected for failure test

(cherry picked from commit cc8227d)
@Satellite-QE Satellite-QE requested a review from a team as a code owner March 5, 2024 08:40
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Mar 5, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py::test_negative_generate_curl_command_and_fail_registration_intentionally

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Mar 5, 2024
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py::test_negative_verify_bash_exit_status_failing_host_registration

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 5952
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_registration.py::test_negative_verify_bash_exit_status_failing_host_registration --external-logging
Test Result : ================== 3 passed, 41 warnings in 761.74s (0:12:41) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 5, 2024
@Satellite-QE Satellite-QE merged commit 665a796 into 6.15.z Mar 5, 2024
15 of 16 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.15.z-cc8227d29c5ad4828ba7bd8e5a4f9b24c89168f5 branch March 5, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amolpati30 amolpati30

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @Gauravtalreja1 @amolpati30