Wait for product HTTP Proxy update to finish #14269

vsedmik · 2024-03-06T08:50:28Z

Problem Statement

CLI test_positive_assign_http_proxy_to_products is flaky, it looks like the repo properties were not set in time (of assertion).

Solution

Wait for the Update repo tasks to finish.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_http_proxy.py -k test_positive_assign_http_proxy_to_products

vsedmik · 2024-03-06T08:51:11Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_http_proxy.py -k test_positive_assign_http_proxy_to_products

Satellite-QE · 2024-03-06T09:10:24Z

PRT Result

Build Number: 5957
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_http_proxy.py -k test_positive_assign_http_proxy_to_products --external-logging
Test Result : =========== 1 passed, 4 deselected, 11 warnings in 827.63s (0:13:47) ===========

Satellite-QE · 2024-03-06T09:29:26Z

PRT Result

Build Number: 5958
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_http_proxy.py -k test_positive_assign_http_proxy_to_products 
Test Result : =========== 1 passed, 4 deselected, 11 warnings in 813.57s (0:13:33) ===========

vsedmik · 2024-03-06T09:33:44Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_http_proxy.py

Satellite-QE · 2024-03-06T09:55:26Z

PRT Result

Build Number: 5959
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_http_proxy.py --external-logging
Test Result : =========== 3 passed, 2 deselected, 53 warnings in 826.34s (0:13:46) ===========

Satellite-QE · 2024-03-06T10:25:05Z

PRT Result

Build Number: 5960
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_http_proxy.py 
Test Result : =========== 3 passed, 2 deselected, 54 warnings in 868.71s (0:14:28) ===========

damoore044

ack looks like the latest prt fail is unrelated, prior runs pass, looks good

devendra104 · 2024-03-06T18:13:47Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_http_proxy.py

Satellite-QE · 2024-03-06T18:36:34Z

PRT Result

Build Number: 5968
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_http_proxy.py --external-logging
Test Result : =========== 3 passed, 2 deselected, 54 warnings in 868.84s (0:14:28) ===========

sambible

ltgtm ( need to fix code quality issues first )

vsedmik · 2024-03-06T20:12:59Z

ltgtm ( need to fix code quality issues first )

CI/CQ failure seems unrelated - fails in install requirements with

Collecting ssh2-python@ git+https://github.com/jacobcallahan/ssh2-python.git (from broker->-r requirements.txt (line 39))
  Cloning https://github.com/jacobcallahan/ssh2-python.git to /tmp/pip-install-f3qy5lmn/ssh2-python_95c76781e5bb4d7bbbc4f2ab212b31bd
  Running command git clone --filter=blob:none --quiet https://github.com/jacobcallahan/ssh2-python.git /tmp/pip-install-f3qy5lmn/ssh2-python_95c76781e5bb4d7bbbc4f2ab212b31bd
  Downloading ci/appveyor/zlib1211.zip (747 KB)
  Error downloading object: ci/appveyor/zlib1211.zip (d7510a8): Smudge error: Error downloading ci/appveyor/zlib1211.zip (d7510a8ee1918b7d0cad197a089c0a2cd4d6df05fee22389f67f115e738b178d): batch

vijaysawant

One optional suggestion to swap argurment as per function/wait_for_tasks definition.
Would it be possible to assert on return value of function as function returns the list of ForemanTask entities? https://github.com/SatelliteQE/robottelo/blob/master/robottelo/host_helpers/capsule_mixins.py#L29

tests/foreman/cli/test_http_proxy.py

vijaysawant · 2024-03-07T07:26:46Z

tests/foreman/cli/test_http_proxy.py

@@ -272,6 +272,13 @@ def test_positive_assign_http_proxy_to_products(module_org, module_target_sat):
        }
    )
    assert 'Product proxy updated' in res
+    module_target_sat.wait_for_tasks(


I beleive this function returns List of sat.api.ForemanTask entities, would it be possible to use assersion on return value for this call?

vijaysawant · 2024-03-07T07:26:53Z

tests/foreman/cli/test_http_proxy.py

@@ -293,6 +300,13 @@ def test_positive_assign_http_proxy_to_products(module_org, module_target_sat):
        {'ids': f"{product_a['id']},{product_b['id']}", 'http-proxy-policy': 'none'}
    )
    assert 'Product proxy updated' in res
+    module_target_sat.wait_for_tasks(


I beleive this function returns List of sat.api.ForemanTask entities, would it be possible to use assersion on return value for this call?

Yup it returns a list of found tasks. However, since they are read before the pull loop, some of them are pending. So I'm fine with the subsequential assertion...

vsedmik · 2024-03-07T10:02:14Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_http_proxy.py

Satellite-QE · 2024-03-07T10:27:15Z

PRT Result

Build Number: 5973
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_http_proxy.py --external-logging
Test Result : =========== 3 passed, 2 deselected, 55 warnings in 895.57s (0:14:55) ===========

(cherry picked from commit 9012e2f)

vsedmik added 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches labels Mar 6, 2024

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 6, 2024

vsedmik marked this pull request as ready for review March 6, 2024 16:10

vsedmik requested a review from a team as a code owner March 6, 2024 16:10

vsedmik added the Easy Fix :) Easiest Fix to review and quick merge request. label Mar 6, 2024

github-actions bot assigned vsedmik Mar 6, 2024

damoore044 approved these changes Mar 6, 2024

View reviewed changes

sambible approved these changes Mar 6, 2024

View reviewed changes

vijaysawant requested changes Mar 7, 2024

View reviewed changes

Wait for product HTTP Proxy update to finish

50b09ac

vsedmik force-pushed the http-cli-flakiness branch from d73c742 to 50b09ac Compare March 7, 2024 09:33

vijaysawant approved these changes Mar 7, 2024

View reviewed changes

vsedmik added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Mar 7, 2024

vijaysawant merged commit 9012e2f into SatelliteQE:master Mar 7, 2024
8 checks passed

github-actions bot pushed a commit that referenced this pull request Mar 7, 2024

Wait for product HTTP Proxy update to finish (#14269)

b18b34f

(cherry picked from commit 9012e2f)

Satellite-QE mentioned this pull request Mar 7, 2024

[6.15.z] Wait for product HTTP Proxy update to finish #14284

Merged

github-actions bot pushed a commit that referenced this pull request Mar 7, 2024

Wait for product HTTP Proxy update to finish (#14269)

b1d0370

(cherry picked from commit 9012e2f)

Satellite-QE mentioned this pull request Mar 7, 2024

[6.13.z] Wait for product HTTP Proxy update to finish #14285

Merged

github-actions bot pushed a commit that referenced this pull request Mar 7, 2024

Wait for product HTTP Proxy update to finish (#14269)

dda606c

(cherry picked from commit 9012e2f)

Satellite-QE mentioned this pull request Mar 7, 2024

[6.14.z] Wait for product HTTP Proxy update to finish #14286

Merged

shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024

Wait for product HTTP Proxy update to finish (SatelliteQE#14269)

7bcc319

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wait for product HTTP Proxy update to finish #14269

Wait for product HTTP Proxy update to finish #14269

vsedmik commented Mar 6, 2024

vsedmik commented Mar 6, 2024

Satellite-QE commented Mar 6, 2024

Satellite-QE commented Mar 6, 2024

vsedmik commented Mar 6, 2024

Satellite-QE commented Mar 6, 2024

Satellite-QE commented Mar 6, 2024

damoore044 left a comment

devendra104 commented Mar 6, 2024

Satellite-QE commented Mar 6, 2024

sambible left a comment

vsedmik commented Mar 6, 2024

vijaysawant left a comment

vijaysawant Mar 7, 2024

vijaysawant Mar 7, 2024

vsedmik Mar 7, 2024

vsedmik commented Mar 7, 2024

Satellite-QE commented Mar 7, 2024

Wait for product HTTP Proxy update to finish #14269

Wait for product HTTP Proxy update to finish #14269

Conversation

vsedmik commented Mar 6, 2024

Problem Statement

Solution

PRT test Cases example

vsedmik commented Mar 6, 2024

Satellite-QE commented Mar 6, 2024

Satellite-QE commented Mar 6, 2024

vsedmik commented Mar 6, 2024

Satellite-QE commented Mar 6, 2024

Satellite-QE commented Mar 6, 2024

damoore044 left a comment

Choose a reason for hiding this comment

devendra104 commented Mar 6, 2024

Satellite-QE commented Mar 6, 2024

sambible left a comment

Choose a reason for hiding this comment

vsedmik commented Mar 6, 2024

vijaysawant left a comment

Choose a reason for hiding this comment

vijaysawant Mar 7, 2024

Choose a reason for hiding this comment

vijaysawant Mar 7, 2024

Choose a reason for hiding this comment

vsedmik Mar 7, 2024

Choose a reason for hiding this comment

vsedmik commented Mar 7, 2024

Satellite-QE commented Mar 7, 2024