Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add posibility to filter tests that require manifester #14270

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

dosas
Copy link
Collaborator

@dosas dosas commented Mar 6, 2024

Problem Statement

We cannot run tests that require manifester

Solution

Add pytest marker to filter these tests if required

Related Issues

@dosas dosas requested review from a team as code owners March 6, 2024 09:29
@dosas
Copy link
Collaborator Author

dosas commented Mar 6, 2024

😮

install-4916ssk1/ssh2-python_5d99b5d22fac449f9ff3a4840ec5cac6
  Downloading ci/appveyor/zlib1211.zip (747 KB)
  Error downloading object: ci/appveyor/zlib1211.zip (d7510a8): Smudge error: Error downloading ci/appveyor/zlib1211.zip (d7510a8ee1918b7d0cad197a089c0a2cd4d6df05fee22389f67f115e738b178d): batch response: This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.

@ogajduse
Copy link
Member

ogajduse commented Mar 6, 2024

😮

install-4916ssk1/ssh2-python_5d99b5d22fac449f9ff3a4840ec5cac6
  Downloading ci/appveyor/zlib1211.zip (747 KB)
  Error downloading object: ci/appveyor/zlib1211.zip (d7510a8): Smudge error: Error downloading ci/appveyor/zlib1211.zip (d7510a8ee1918b7d0cad197a089c0a2cd4d6df05fee22389f67f115e738b178d): batch response: This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.

I believe this could be fixed by SatelliteQE/broker#271 and bumping a broker version in robottelo's requirements.

@dosas dosas force-pushed the filter-manifester-tests branch from dc52895 to a2334d8 Compare March 12, 2024 10:55
@dosas
Copy link
Collaborator Author

dosas commented Mar 12, 2024

Tests are passing after rebase

Copy link
Contributor

@synkd synkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a helpful addition. Thank you @dosas for your contribution.

@dosas
Copy link
Collaborator Author

dosas commented Mar 14, 2024

Sadly I cannot add labels. So somebody else has to do it :D

@jyejare jyejare added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 15, 2024
@jyejare jyejare enabled auto-merge (squash) March 15, 2024 07:35
@jyejare jyejare merged commit 0397a0d into SatelliteQE:master Mar 15, 2024
11 of 12 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
Gauravtalreja1 pushed a commit that referenced this pull request Mar 15, 2024
Add posibility to filter tests that require manifester (#14270)

(cherry picked from commit 0397a0d)

Co-authored-by: dosas <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Mar 15, 2024
Add posibility to filter tests that require manifester (#14270)

(cherry picked from commit 0397a0d)

Co-authored-by: dosas <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Mar 15, 2024
Add posibility to filter tests that require manifester (#14270)

(cherry picked from commit 0397a0d)

Co-authored-by: dosas <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Mar 15, 2024
Add posibility to filter tests that require manifester (#14270)

(cherry picked from commit 0397a0d)

Co-authored-by: dosas <[email protected]>
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Mar 18, 2024
…lliteQE#14415)

Add posibility to filter tests that require manifester (SatelliteQE#14270)

(cherry picked from commit 0397a0d)

Co-authored-by: dosas <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants