Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend ansible-roles add/remove test for nested HG #14272

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Extend ansible-roles add/remove test for nested HG #14272

merged 2 commits into from
Mar 7, 2024

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

As part of component audit, it was suggested to cover a test for ansible roles assign/add/remove on nested host group, like normal or parent host group

Solution

Extend existing ansible-roles assign/add/remove test for nested hostgroups, similar to normal or parent host group in API

@Gauravtalreja1 Gauravtalreja1 added API Issues and PRs involving the API QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 6, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this Mar 6, 2024
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner March 6, 2024 15:30
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py -k test_add_and_remove_ansible_role_hostgroup

@devendra104
Copy link
Member

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py -k test_add_and_remove_ansible_role_hostgroup

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5967
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_ansible.py -k test_add_and_remove_ansible_role_hostgroup --external-logging
Test Result : ========== 1 passed, 10 deselected, 11 warnings in 726.31s (0:12:06) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 6, 2024
shubhamsg199
shubhamsg199 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@shubhamsg199 shubhamsg199 merged commit 808efeb into SatelliteQE:master Mar 7, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 7, 2024
@Gauravtalreja1 @web-flow
Extend ansible-roles add/remove test for nested HG (#14272)
955e43c 
* Extend ansible-roles add/remove test for nested HG

Signed-off-by: Gaurav Talreja <[email protected]>

* Fix step 1 in docstring as per grammer

Co-authored-by: Shubham Ganar <[email protected]>

---------

Signed-off-by: Gaurav Talreja <[email protected]>
Co-authored-by: Shubham Ganar <[email protected]>
(cherry picked from commit 808efeb)
@Satellite-QE Satellite-QE mentioned this pull request Mar 7, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Mar 7, 2024
@Gauravtalreja1 @web-flow
Extend ansible-roles add/remove test for nested HG (#14272)
6c72a66 
* Extend ansible-roles add/remove test for nested HG

Signed-off-by: Gaurav Talreja <[email protected]>

* Fix step 1 in docstring as per grammer

Co-authored-by: Shubham Ganar <[email protected]>

---------

Signed-off-by: Gaurav Talreja <[email protected]>
Co-authored-by: Shubham Ganar <[email protected]>
(cherry picked from commit 808efeb)
@Satellite-QE Satellite-QE mentioned this pull request Mar 7, 2024
Merged
@Gauravtalreja1 Gauravtalreja1 deleted the ansible-nested-hg-add-remove branch March 7, 2024 12:04
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@Gauravtalreja1 @shubhamsg199 @shweta83
Extend ansible-roles add/remove test for nested HG (SatelliteQE#14272)
f53f8a1 
* Extend ansible-roles add/remove test for nested HG

Signed-off-by: Gaurav Talreja <[email protected]>

* Fix step 1 in docstring as per grammer

Co-authored-by: Shubham Ganar <[email protected]>

---------

Signed-off-by: Gaurav Talreja <[email protected]>
Co-authored-by: Shubham Ganar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 API Issues and PRs involving the API AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauravtalreja1 @devendra104 @Satellite-QE @shubhamsg199