[6.15.z] Fix flaky SyncPlans in cli_factory #14351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #14337
Problem Statement
Some CLI SyncPlan tests are failing randomly. The reason is that
cli_factory
takes randominterval
(when not provided explicitly) in options and ignores thatcustom cron
needs additionalcron-interval
option, so the tests fail on validation.Plus one small param fix forgotten in CLI refactor.
Solution
Do not pick
custom cron
randomly from factory and check thecron-interval
is provided whencustom cron
is used.PRT test Cases example
trigger: test-robottelo
pytest: tests/foreman/cli/test_syncplan.py