Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Mark fake secret as "notsecret" #14361

Merged
merged 1 commit into from
Mar 11, 2024
Merged

[6.15.z] Mark fake secret as "notsecret" #14361

merged 1 commit into from
Mar 11, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14336

Problem Statement

Internal pre-commit hook complains on this line. It assumes that we are revealing a secret.

Solution

Add a comment at the end of the line to tell the hook that it is not a secret.

@Satellite-QE Satellite-QE requested a review from a team as a code owner March 11, 2024 19:10
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Mar 11, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit f40dc16 into 6.15.z Mar 11, 2024
11 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.15.z-98f375db26787e031e259ffe332740330bea45ba branch March 11, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@ogajduse ogajduse

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @Gauravtalreja1 @ogajduse