Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update fixture name as per expected feature #14375

Merged
merged 2 commits into from
Mar 13, 2024
Merged

update fixture name as per expected feature #14375

merged 2 commits into from
Mar 13, 2024

Conversation

vijaysawant
Copy link
Contributor

Problem Statement

test test_positive_async_endpoint_for_manifest_refresh was failing due to manifest issue inside module_entitlement_manifest_org > upload_manifest
Basically unable to upload manifest and return org, as per current feature we are supposed to use sca enabled organization

Solution

This PR would fix the issue

Related Issues

N/A

@vijaysawant vijaysawant added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 12, 2024
@vijaysawant vijaysawant requested a review from a team as a code owner March 12, 2024 13:21
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py -k 'test_positive_async_endpoint_for_manifest_refresh'

damoore044
damoore044 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack. pending passing result once testing is back up

vsedmik
vsedmik approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure was This subscription management application has already been imported by another owner., which would lead me to use rather function-scoped manifest.

But for stream/6.16 we will need SCA anyway, so ACK for now but wait for PRT (which is blocked RN)

@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py -k 'test_positive_async_endpoint_for_manifest_refresh'

@vijaysawant
Copy link
Contributor Author

PRT job failing, unable to install requirements succefully, ssh2-python package failed to installed

Local execution result:

============================= test session starts ==============================
collecting ... 2024-03-13 15:15:19 - robottelo.collection - INFO - Processing test items to add testimony token markers
collected 18 items / 17 deselected / 1 selected

tests/foreman/api/test_subscription.py::test_positive_async_endpoint_for_manifest_refresh 

========== 1 passed, 17 deselected, 82 warnings in 243.02s (0:04:03) ===========
PASSED

@vijaysawant vijaysawant force-pushed the small_fix_TFA_manifest_issue branch from 0fddc13 to 16b0b0c Compare March 13, 2024 14:27
@vsedmik
Copy link
Contributor

vsedmik commented Mar 13, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py -k 'test_positive_async_endpoint_for_manifest_refresh'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6053
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_subscription.py -k test_positive_async_endpoint_for_manifest_refresh --external-logging
Test Result : =========== 1 passed, 17 deselected, 1 warning in 1335.16s (0:22:15) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 13, 2024
@vsedmik vsedmik merged commit 80c2bbc into SatelliteQE:master Mar 13, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 13, 2024
@vijaysawant @web-flow
update fixture name as per expected feature (#14375)
4efacc3 
* update fixture name as per expected feature

* addressed review comments

(cherry picked from commit 80c2bbc)
@Satellite-QE Satellite-QE mentioned this pull request Mar 13, 2024
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@vijaysawant @shweta83
update fixture name as per expected feature (SatelliteQE#14375)
760aa54 
* update fixture name as per expected feature

* addressed review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damoore044 damoore044 damoore044 approved these changes

@vsedmik vsedmik vsedmik approved these changes

Assignees

@vijaysawant vijaysawant

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vijaysawant @vsedmik @Satellite-QE @damoore044