Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virt-who config upgrade duplicate config issue fix #14378

Conversation

yanpliu
Copy link
Contributor

@yanpliu yanpliu commented Mar 13, 2024

when the virt-who upgrade tests failed for some issues, delete virt-who config will failed, then rerun the upgrade testing, it will create another virt-who config in other org, but when list or check info the config, it will list the first virt-who config.

Use auto name to fix it.
Test Case: PASS

(robottelo_vv_615) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/upgrades/test_virtwho.py  -m pre_upgrade --disable-pytest-warnings -q
.                                                                                                                                                                                                                                      [100%]
1 passed, 1 deselected, 20 warnings in 188.91s (0:03:08)
(robottelo_vv_615) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/upgrades/test_virtwho.py  -m post_upgrade --disable-pytest-warnings -q
.                                                                                                                                                                                                                                      [100%]
1 passed, 1 deselected, 12 warnings in 136.32s (0:02:16)

@yanpliu yanpliu added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 13, 2024
@yanpliu yanpliu self-assigned this Mar 13, 2024
@yanpliu yanpliu requested a review from a team as a code owner March 13, 2024 07:01
@lhellebr
Copy link
Contributor

Code-wise ~LGTM but there are CQ failures (failed on setup so I reran them for you) and PRT hasn't run yet (so you should run it).

@yanpliu
Copy link
Contributor Author

yanpliu commented Mar 20, 2024

Code-wise ~LGTM but there are CQ failures (failed on setup so I reran them for you) and PRT hasn't run yet (so you should run it).

@lhellebr I have rerun the jobs, but they all failed for "ERROR: No matching distribution found for ssh2-python (unavailable)"

@Gauravtalreja1 Gauravtalreja1 force-pushed the virtwho_config_upgrade_duplicated_config_name_fix branch from 67639e5 to c9e7696 Compare March 22, 2024 19:12
@Gauravtalreja1 Gauravtalreja1 enabled auto-merge (squash) March 22, 2024 19:14
@Gauravtalreja1 Gauravtalreja1 merged commit 980392e into SatelliteQE:master Mar 22, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 22, 2024
github-actions bot pushed a commit that referenced this pull request Mar 22, 2024
Gauravtalreja1 pushed a commit that referenced this pull request Mar 22, 2024
virt-who config upgrade duplicate config issue fix (#14378)

(cherry picked from commit 980392e)

Co-authored-by: yanpliu <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Mar 22, 2024
virt-who config upgrade duplicate config issue fix (#14378)

(cherry picked from commit 980392e)

Co-authored-by: yanpliu <[email protected]>
@yanpliu yanpliu deleted the virtwho_config_upgrade_duplicated_config_name_fix branch March 25, 2024 01:36
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants