-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virt-who config upgrade duplicate config issue fix #14378
Merged
Gauravtalreja1
merged 1 commit into
SatelliteQE:master
from
yanpliu:virtwho_config_upgrade_duplicated_config_name_fix
Mar 22, 2024
Merged
virt-who config upgrade duplicate config issue fix #14378
Gauravtalreja1
merged 1 commit into
SatelliteQE:master
from
yanpliu:virtwho_config_upgrade_duplicated_config_name_fix
Mar 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code-wise ~LGTM but there are CQ failures (failed on setup so I reran them for you) and PRT hasn't run yet (so you should run it). |
@lhellebr I have rerun the jobs, but they all failed for "ERROR: No matching distribution found for ssh2-python (unavailable)" |
67639e5
to
c9e7696
Compare
Gauravtalreja1
approved these changes
Mar 22, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
(cherry picked from commit 980392e)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
(cherry picked from commit 980392e)
This was referenced Mar 22, 2024
Gauravtalreja1
pushed a commit
that referenced
this pull request
Mar 22, 2024
virt-who config upgrade duplicate config issue fix (#14378) (cherry picked from commit 980392e) Co-authored-by: yanpliu <[email protected]>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Mar 22, 2024
virt-who config upgrade duplicate config issue fix (#14378) (cherry picked from commit 980392e) Co-authored-by: yanpliu <[email protected]>
shweta83
pushed a commit
to shweta83/robottelo
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.13.z
Introduced in or relating directly to Satellite 6.13
6.14.z
Introduced in or relating directly to Satellite 6.14
6.15.z
Introduced in or relating directly to Satellite 6.15
CherryPick
PR needs CherryPick to previous branches
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the virt-who upgrade tests failed for some issues, delete virt-who config will failed, then rerun the upgrade testing, it will create another virt-who config in other org, but when list or check info the config, it will list the first virt-who config.
Use auto name to fix it.
Test Case: PASS