Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customer Case Automation - repo ids not being displayed #14400

Merged
merged 7 commits into from
May 16, 2024
Merged

Customer Case Automation - repo ids not being displayed #14400

merged 7 commits into from
May 16, 2024

Conversation

sambible
Copy link
Contributor

Customer Case/CV Eval Automation for https://bugzilla.redhat.com/show_bug.cgi?id=2141421

Also includes a new CLI endpoint "hammer content-view list" to support it.

@sambible sambible added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 13, 2024
@sambible sambible self-assigned this Mar 13, 2024
@sambible sambible requested review from a team as code owners March 13, 2024 22:12
rmynar
rmynar requested changes Mar 14, 2024
View reviewed changes
robottelo/cli/contentview.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_contentview.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_contentview.py Outdated Show resolved Hide resolved
@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py -k "test_show_all_repo_ids"

vsedmik
vsedmik reviewed Mar 18, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one suggestion to consider.

tests/foreman/cli/test_contentview.py Outdated Show resolved Hide resolved
@sambible sambible requested a review from a team as a code owner May 15, 2024 18:42
@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py -k "test_show_all_repo_ids"

@damoore044
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py::TestContentView::test_show_all_repo_ids

damoore044
damoore044 approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no prt output but show a pass in jenkins.
ack pending the one comment

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6943
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_contentview.py::TestContentView::test_show_all_repo_ids --external-logging
Test Result : ================== 1 passed, 9 warnings in 1078.98s (0:17:58) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 15, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 15, 2024
@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py::TestContentView::test_show_all_repo_ids

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6948
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_contentview.py::TestContentView::test_show_all_repo_ids --external-logging
Test Result : ================== 1 failed, 9 warnings in 1121.36s (0:18:41) ==================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 15, 2024
@vsedmik
Copy link
Contributor

vsedmik commented May 16, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py::TestContentView::test_show_all_repo_ids

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6952
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_contentview.py::TestContentView::test_show_all_repo_ids --external-logging
Test Result : ================== 1 passed, 9 warnings in 1036.40s (0:17:16) ==================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 16, 2024
@vsedmik vsedmik added AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing and removed 6.14.z Introduced in or relating directly to Satellite 6.14 labels May 16, 2024
@vsedmik
Copy link
Contributor

vsedmik commented May 16, 2024

The BZ was fixed in 6.15.0 thus removing 6.14.z label.

@vsedmik vsedmik merged commit 15a9868 into SatelliteQE:master May 16, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request May 16, 2024
@sambible @web-flow
Customer Case Automation - repo ids not being displayed (#14400)
646cb51 
* Customer Case Automation - repo ids not being displayed

* fix cli method description, condense logic

* Use set to be consistent in order

Co-authored-by: vsedmik <[email protected]>

* Update tests/foreman/cli/test_contentview.py

---------

Co-authored-by: vsedmik <[email protected]>
(cherry picked from commit 15a9868)
@Satellite-QE Satellite-QE mentioned this pull request May 16, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@sambible @vsedmik @jyejare
Customer Case Automation - repo ids not being displayed (SatelliteQE#…
47c40d9 
…14400)

* Customer Case Automation - repo ids not being displayed

* fix cli method description, condense logic

* Use set to be consistent in order

Co-authored-by: vsedmik <[email protected]>

* Update tests/foreman/cli/test_contentview.py

---------

Co-authored-by: vsedmik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik left review comments

@shweta83 shweta83 shweta83 left review comments

@damoore044 damoore044 damoore044 approved these changes

@rmynar rmynar rmynar approved these changes

@synkd synkd synkd approved these changes

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@sambible sambible

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sambible @damoore044 @Satellite-QE @vsedmik @lhellebr @ColeHiggins2 @shweta83 @synkd @rmynar