Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.12.z] - remove the all nailgun imports from UI folder #14433

Conversation

omkarkhatavkar
Copy link

Problem Statement

We are using the direct imports from the nailgun rather than directly using from target_sat

Solution

Direct Imports Removed: We've cleaned up our codebase by eliminating direct imports from the Nailgun package.

Using target_sat, module_target_sat, class_target_sat: Modified the API calls and using the target_sat.api. pattern for all API calls.

@omkarkhatavkar omkarkhatavkar added the 6.12.z Introduced in or relating directly to Satellite 6.12 label Mar 18, 2024
@omkarkhatavkar omkarkhatavkar added No-CherryPick PR doesnt need CherryPick to previous branches Failed_AutoCherryPick Issue for failed/conflicted auto cherry pick of PRs labels Mar 18, 2024
@omkarkhatavkar
Copy link
Author

trigger: test-robottelo
pytest: tests/foreman/ui/ -m e2e

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6103
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/ -m e2e --external-logging
Test Result : = 5 failed, 5 passed, 787 deselected, 843 warnings, 3 errors in 5789.77s (1:36:29) =

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 18, 2024
@Gauravtalreja1 Gauravtalreja1 force-pushed the cherry-pick-failure-13809-4 branch from 4304b10 to 4624e6a Compare March 22, 2024 19:10
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/ui/

@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 22, 2024
@Gauravtalreja1
Copy link
Collaborator

@omkarkhatavkar Could you rebase and update this PR?

@omkarkhatavkar omkarkhatavkar force-pushed the cherry-pick-failure-13809-4 branch from 4624e6a to 6bc35a7 Compare April 15, 2024 05:51
@omkarkhatavkar
Copy link
Author

@Gauravtalreja1 @jyejare Rebase Done !

@Gauravtalreja1
Copy link
Collaborator

@omkarkhatavkar Could you rebase this PR again?

Copy link
Contributor

@pnovotny pnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Rebase & conflicts resolve needed.

@omkarkhatavkar
Copy link
Author

6.12.z is now absolute hence closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 Failed_AutoCherryPick Issue for failed/conflicted auto cherry pick of PRs No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants