Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.14.z] duplicate bookmark negative test fix #14454

Merged

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14232

Problem Statement

With SatelliteQE/airgun#1200 in, another problem uncovered in bookmarks. Trying to create a bookmark with already existing name doesn't raise exception in old style dialog (wontfix bz 1992652), it does so in the new style dialog (different one in stream than in 6.x runs). Affects ~20 tests

Solution

this pr attempts to cover all the cases

@Satellite-QE Satellite-QE added 6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Mar 20, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_bookmarks.py -k test_negative_create_with_duplicate_name

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Mar 20, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6141
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_bookmarks.py -k test_negative_create_with_duplicate_name --external-logging
Test Result : = 7 failed, 29 passed, 1 skipped, 156 deselected, 125 warnings, 2 errors in 2586.70s (0:43:06) =

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 20, 2024
@pondrejk
Copy link
Contributor

The failures pattern matches the master run, failures not related to changes from this PR (more investigation needed on the airgun side )

@pondrejk pondrejk merged commit 4741463 into 6.14.z Mar 20, 2024
23 of 26 checks passed
@pondrejk pondrejk deleted the cherry-pick-6.14.z-e44a553097568f44bdbb589cbd125b499a00eaed branch March 20, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants