Fix upstream api permission tests

[dosas]

Problem Statement

API permission tests failing for upstream

Solution

• add more checks for installed rpm packages
• speedup by querying rpm -qa ony once
• some tests were not updated with this commit 6651dd6#diff-9a55ae74469aa91ad5efb2b9068f73174467cd0c00d45abf7d35f9f2277a7632

Relevant tests:

tests/foreman/cli/test_role.py
tests/foreman/api/test_role.py
tests/foreman/api/test_permission.py

[ogajduse]

@pondrejk @lhellebr @pnovotny Can you please take a look at @dosas's PR? It is touching a module that belongs to your team.

[lhellebr]

There are more rpm conditions than previously. Have tests failed on these in upstream?

[dosas]

Since upstream is defined as

# rpm -q satellite-capsule
package satellite-capsule is not installed

yes they failed.

[ogajduse]

robottelo/robottelo/hosts.py

Lines 1540 to 1547 in 21580fc

	@cached_property
	def is_upstream(self):
	"""Figure out which product distribution is installed on the server.
	:return: True if no downstream satellite RPMS are installed
	:rtype: bool
	"""
	return self.execute(f'rpm -q {self.product_rpm_name}').status != 0

What I got from your comment is that the current implementation of is_upstream does not suit you. Is that correct?

[dosas]

I do not really have an issue with it. It is just more a check for 'not downstream satellite'.
I am not really running the tests on upstream but a different downstream so it kind of helps me I guess.

[JacobCallahan]

@dosas is correct here that the missing presence of Satellite rpms isn't the most accurate test of whether we're in an upstream/downstream environment or not.

[dosas]

@lhellebr To answer your original questions: Yes there are more conditions because there are also more permissions that were added.

IMO the definition of is_upstream is out of scope of this PR.

[pondrejk]

trigger: test-robottelo
pytest: tests/foreman/api/test_permission.py -k test_positive_search

[Satellite-QE]

PRT Result

Build Number: 6545
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_permission.py -k test_positive_search --external-logging
Test Result : ========== 3 passed, 13 deselected, 114 warnings in 812.58s (0:13:32) ==========

[dosas]

@pondrejk Why did you remove the labels?

[pondrejk]

hi @dosas, I checked out this branch locally and ran some tests from the affected files, all seems well, prt also passes so I'm ok with merging this, thanks for the contribution. I reckoned that downstream branches would not be of interest to you, so I changed the labels. If you need those cherry picks I can put them back

[dosas]

hi @dosas, I checked out this branch locally and ran some tests from the affected files, all seems well, prt also passes so I'm ok with merging this, thanks for the contribution. I reckoned that downstream branches would not be of interest to you, so I changed the labels. If you need those cherry picks I can put them back

I would require 6.15.z please