Verify a variable created and added to the host #14477

shweta83 · 2024-03-21T19:13:52Z

Problem Statement

We are missing scenario for creating and adding variable to the host.
Automated BZ: 2170727

Solution

Added the scenario

Related Issues

shweta83 · 2024-03-21T19:14:36Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py -k test_positive_verify_ansible_role_on_host

shweta83 · 2024-03-21T19:16:20Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py -k test_positive_verify_ansible_variable_on_host

Satellite-QE · 2024-03-21T19:59:54Z

PRT Result

Build Number: 6160
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py -k test_positive_verify_ansible_variable_on_host --external-logging
Test Result : =========== 1 passed, 10 deselected, 4 warnings in 804.09s (0:13:24) ===========

Gauravtalreja1 · 2024-03-22T07:18:28Z

tests/foreman/ui/test_ansible.py

+        session.ansiblevariables.create_with_overrides(
+            {
+                'key': key,
+                'ansible_role': SELECTED_ROLE,
+                'override': 'true',
+                'parameter_type': 'array',
+                'default_value': '[\'test\']',
+                'validator_type': None,
+                'attribute_order': 'domain \n fqdn \n hostgroup \n os',


It looks like this test is just extending the existing test_positive_create_variable_with_overrides, so can we combine this two tests by adding a assert for verifying if variable is created or etc?

The existing test is taking integer type and the BZ was specific about array(which will contain string) type.

Gauravtalreja1 · 2024-03-22T07:22:54Z

tests/foreman/ui/test_ansible.py

+        values = session.host_new.get_details(rhel_contenthost.hostname, 'ansible')['ansible'][
+            'variables'
+        ]['table']


Can we add a check for verifying the assigned role here first on host then variable?

We already have the test for it test_positive_host_role_information, so if you agree on this we can combine this too and remove the existing test?

It doesn't matter here. But I can surely add it.

well, you're asserting for var['Ansible role'] currently, but what I meant was that in the Ansible tab, check the roles subtab rather than the variables subtab, for roles assigned as similar to test_positive_host_role_information

I am verifying the role has been assigned to the variable which is needed for the this test.

its a good thing to check, but its fine, we can skip this check for now

tests/foreman/ui/test_ansible.py

Gauravtalreja1 · 2024-03-22T07:30:06Z

tests/foreman/ui/test_ansible.py

+    command = target_sat.api.RegistrationCommand(
+        organization=module_org,
+        location=module_location,
+        activation_keys=[module_activation_key.name],
+    ).create()
+    result = rhel_contenthost.execute(command)


As you're not using the host here, so you could skip the rhel_contenthost and its registration, instead create a fake host without registration and assign the role directly

Good to use the actual host here.

Either way, this should be setup.

yes, it is part of setup, but we're using fake hosts everywhere for such tests for Ansible component, also this will make the execution faster and will save time for unnecessary checkout of actual host

It is using container so it doesn't take much time.

tests/foreman/ui/test_ansible.py

shweta83 · 2024-03-22T17:14:55Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py -k test_positive_assign_ansible_role_variable_on_host

Satellite-QE · 2024-03-22T17:35:14Z

PRT Result

Build Number: 6171
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_ansible.py -k test_positive_assign_ansible_role_variable_on_host --external-logging
Test Result : =========== 1 failed, 10 deselected, 4 warnings in 833.11s (0:13:53) ===========

Satellite-QE · 2024-03-22T18:54:30Z

PRT Result

Build Number: 6172
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py -k test_positive_assign_ansible_role_variable_on_host --external-logging
Test Result : =========== 1 passed, 10 deselected, 4 warnings in 829.18s (0:13:49) ===========

lhellebr

ACK pending comments

tests/foreman/ui/test_ansible.py

shweta83 · 2024-04-03T19:14:49Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py -k test_positive_verify_ansible_variable_on_host

shweta83 · 2024-04-04T06:49:30Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py -k test_positive_assign_ansible_role_variable_on_host

Satellite-QE · 2024-04-04T07:10:23Z

PRT Result

Build Number: 6306
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py -k test_positive_assign_ansible_role_variable_on_host --external-logging
Test Result : =========== 1 passed, 10 deselected, 7 warnings in 825.40s (0:13:45) ===========

shweta83 · 2024-04-04T09:22:24Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py -k test_positive_assign_ansible_role_variable_on_host

Satellite-QE · 2024-04-04T09:45:29Z

PRT Result

Build Number: 6309
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py -k test_positive_assign_ansible_role_variable_on_host --external-logging
Test Result : =========== 1 passed, 10 deselected, 7 warnings in 841.99s (0:14:01) ===========

(cherry picked from commit fc64c78)

shweta83 requested a review from a team as a code owner March 21, 2024 19:13

github-actions bot assigned shweta83 Mar 21, 2024

shweta83 force-pushed the automate_customer_scenario branch from 8db1360 to 65d44b5 Compare March 21, 2024 19:15

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 21, 2024

Gauravtalreja1 reviewed Mar 22, 2024

View reviewed changes

tests/foreman/ui/test_ansible.py Outdated Show resolved Hide resolved

Gauravtalreja1 reviewed Mar 22, 2024

View reviewed changes

tests/foreman/ui/test_ansible.py Outdated Show resolved Hide resolved

Gauravtalreja1 reviewed Mar 22, 2024

View reviewed changes

tests/foreman/ui/test_ansible.py Outdated Show resolved Hide resolved

Gauravtalreja1 added the QETestCoverage Issues and PRs relating to a Satellite bug label Mar 22, 2024

Gauravtalreja1 reviewed Mar 22, 2024

View reviewed changes

tests/foreman/ui/test_ansible.py Show resolved Hide resolved

shweta83 force-pushed the automate_customer_scenario branch from 65d44b5 to 597cedd Compare March 22, 2024 17:14

Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Mar 22, 2024

shweta83 force-pushed the automate_customer_scenario branch from 597cedd to 72bbe92 Compare March 22, 2024 18:36

Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 22, 2024

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 22, 2024

lhellebr approved these changes Mar 26, 2024

View reviewed changes

Gauravtalreja1 reviewed Mar 28, 2024

View reviewed changes

tests/foreman/ui/test_ansible.py Show resolved Hide resolved

shweta83 force-pushed the automate_customer_scenario branch 2 times, most recently from cd8ff11 to b67774c Compare April 3, 2024 19:14

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 3, 2024

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 4, 2024

Verify a variable created and added to the host

a787d66

shweta83 force-pushed the automate_customer_scenario branch from b67774c to a787d66 Compare April 4, 2024 07:26

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 4, 2024

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 4, 2024

Gauravtalreja1 approved these changes Apr 4, 2024

View reviewed changes

Gauravtalreja1 merged commit fc64c78 into SatelliteQE:master Apr 4, 2024
10 checks passed

github-actions bot pushed a commit that referenced this pull request Apr 4, 2024

Verify a variable created and added to the host (#14477)

0f29b1f

(cherry picked from commit fc64c78)

github-actions bot pushed a commit that referenced this pull request Apr 4, 2024

Verify a variable created and added to the host (#14477)

f91ae32

(cherry picked from commit fc64c78)

github-actions bot pushed a commit that referenced this pull request Apr 4, 2024

Verify a variable created and added to the host (#14477)

977eb33

(cherry picked from commit fc64c78)

This was referenced Apr 4, 2024

[6.15.z] Verify a variable created and added to the host #14622

Merged

[6.13.z] Verify a variable created and added to the host #14623

Merged

[6.14.z] Verify a variable created and added to the host #14624

Merged

shweta83 added a commit to shweta83/robottelo that referenced this pull request Apr 5, 2024

Verify a variable created and added to the host (SatelliteQE#14477)

d696890

(cherry picked from commit fc64c78)

shweta83 added a commit that referenced this pull request Apr 5, 2024

Verify a variable created and added to the host (#14477)

0a6de30

(cherry picked from commit fc64c78)

shweta83 added a commit that referenced this pull request Apr 5, 2024

Verify a variable created and added to the host (#14477)

8be64d7

(cherry picked from commit fc64c78)

shweta83 added a commit that referenced this pull request Apr 5, 2024

Verify a variable created and added to the host (#14477)

f33bad5

(cherry picked from commit fc64c78)

shweta83 added a commit that referenced this pull request Apr 5, 2024

Verify a variable created and added to the host (#14477)

dc1e9b8

(cherry picked from commit fc64c78)

shweta83 added a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024

Verify a variable created and added to the host (SatelliteQE#14477)

59009eb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Verify a variable created and added to the host #14477

Verify a variable created and added to the host #14477

shweta83 commented Mar 21, 2024

shweta83 commented Mar 21, 2024

shweta83 commented Mar 21, 2024 •

edited

Loading

Satellite-QE commented Mar 21, 2024

Gauravtalreja1 Mar 22, 2024

shweta83 Mar 22, 2024

Gauravtalreja1 Mar 22, 2024

Gauravtalreja1 Mar 22, 2024

shweta83 Mar 22, 2024

Gauravtalreja1 Mar 28, 2024

shweta83 Apr 3, 2024

Gauravtalreja1 Apr 4, 2024

Gauravtalreja1 Mar 22, 2024

shweta83 Mar 22, 2024

lhellebr Mar 26, 2024

Gauravtalreja1 Mar 28, 2024

shweta83 Apr 4, 2024

shweta83 commented Mar 22, 2024

Satellite-QE commented Mar 22, 2024

Satellite-QE commented Mar 22, 2024

lhellebr left a comment

shweta83 commented Apr 3, 2024

shweta83 commented Apr 4, 2024

Satellite-QE commented Apr 4, 2024

shweta83 commented Apr 4, 2024

Satellite-QE commented Apr 4, 2024

Verify a variable created and added to the host #14477

Verify a variable created and added to the host #14477

Conversation

shweta83 commented Mar 21, 2024

Problem Statement

Solution

Related Issues

shweta83 commented Mar 21, 2024

shweta83 commented Mar 21, 2024 • edited Loading

Satellite-QE commented Mar 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shweta83 commented Mar 22, 2024

Satellite-QE commented Mar 22, 2024

Satellite-QE commented Mar 22, 2024

lhellebr left a comment

Choose a reason for hiding this comment

shweta83 commented Apr 3, 2024

shweta83 commented Apr 4, 2024

Satellite-QE commented Apr 4, 2024

shweta83 commented Apr 4, 2024

Satellite-QE commented Apr 4, 2024

shweta83 commented Mar 21, 2024 •

edited

Loading