Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] Add case for special chars in HTTP proxy password #14570

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14538

Problem Statement

We are missing coverage for a BZ where the HTTP proxy is created with a user containing special characters in his password.

Solution

Not only we need to create the proxy at the Satellite side, we also need to create the user at the proxy side to verify the content operations actually work. In the end I decided to create such users dynamically during the test run, so I needed to add a new ProxyHost class with a few functions to handle that. The class is instantiated in a session-scoped fixture and used in test and other fixture.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_http_proxy.py -k special

@Satellite-QE Satellite-QE requested review from a team as code owners March 28, 2024 15:53
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Mar 28, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_http_proxy.py -k special

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6249
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_http_proxy.py -k special --external-logging
Test Result : =========== 1 failed, 7 deselected, 5 warnings in 795.06s (0:13:15) ============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 28, 2024
@vsedmik
Copy link
Contributor

vsedmik commented Apr 2, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_http_proxy.py -k special

@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 2, 2024
@vsedmik vsedmik added AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing PRT-Failed Indicates that latest PRT run is failed for the PR labels Apr 2, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6270
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_http_proxy.py -k special --external-logging
Test Result : =========== 1 passed, 7 deselected, 5 warnings in 860.89s (0:14:20) ============

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Apr 2, 2024
@Satellite-QE Satellite-QE merged commit de293f1 into 6.15.z Apr 2, 2024
15 of 18 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.15.z-85dd8bc209b9d53f6960c394d7e2173e7e8e2868 branch April 2, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants