Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cu-case-katello-reimport-scenario #14572

Merged
merged 1 commit into from
Apr 2, 2024
Merged

cu-case-katello-reimport-scenario #14572

merged 1 commit into from
Apr 2, 2024

Conversation

vijaysawant
Copy link
Contributor

@vijaysawant vijaysawant commented Mar 28, 2024 •
edited
Loading

Problem Statement

cu coverage
https://bugzilla.redhat.com/show_bug.cgi?id=2225534
https://bugzilla.redhat.com/show_bug.cgi?id=2253621

foreman-rake katello:reimport was failing with TypeError: no implicit conversion of String into Integer

Solution

Discussed scenario around BZ with reporter, decided to use custom expired manifest to test/regenerate scenario
steps:

  1. upload exprired manifest & refresh to fetch Katello::HttpErrors::BadRequest:
  2. delete uploaded manifest, reimport new valid manifest & refresh, it should success.
  3. Additionally check foreman-rake katello:reimport --trace there should not any TypeError

Related Issues

N/A

@vijaysawant vijaysawant added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 28, 2024
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_subscription.py -k 'test_negative_check_katello_reimport'

@vijaysawant vijaysawant marked this pull request as ready for review March 28, 2024 18:59
@vijaysawant vijaysawant requested review from a team as code owners March 28, 2024 18:59
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6250
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_subscription.py -k test_negative_check_katello_reimport --external-logging
Test Result : =========== 1 failed, 10 deselected, 4 warnings in 768.20s (0:12:48) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 28, 2024
@vijaysawant vijaysawant force-pushed the cu-case-manifest-reimport-failed branch from 82f7836 to c5b252b Compare March 30, 2024 07:44
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_subscription.py -k 'test_negative_check_katello_reimport'

@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 30, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6256
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_subscription.py -k test_negative_check_katello_reimport --external-logging
Test Result : =========== 1 passed, 10 deselected, 4 warnings in 863.67s (0:14:23) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 30, 2024
@vijaysawant vijaysawant force-pushed the cu-case-manifest-reimport-failed branch from c5b252b to 0265ec7 Compare March 30, 2024 08:15
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 30, 2024
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_subscription.py -k 'test_negative_check_katello_reimport'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6257
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_subscription.py -k test_negative_check_katello_reimport --external-logging
Test Result : =========== 1 passed, 10 deselected, 4 warnings in 769.39s (0:12:49) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 30, 2024
jyejare
jyejare approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK with nitpicks.

tests/foreman/cli/test_subscription.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_subscription.py Outdated Show resolved Hide resolved
@vijaysawant vijaysawant force-pushed the cu-case-manifest-reimport-failed branch from 0265ec7 to 401c2a2 Compare April 1, 2024 07:26
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_subscription.py -k 'test_negative_check_katello_reimport'

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 1, 2024
@vijaysawant vijaysawant force-pushed the cu-case-manifest-reimport-failed branch from 401c2a2 to 0c3db5d Compare April 1, 2024 07:35
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_subscription.py -k 'test_negative_check_katello_reimport'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6258
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_subscription.py -k test_negative_check_katello_reimport --external-logging
Test Result : =========== 1 passed, 10 deselected, 4 warnings in 793.40s (0:13:13) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 1, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6259
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_subscription.py -k test_negative_check_katello_reimport --external-logging
Test Result : =========== 1 passed, 10 deselected, 4 warnings in 849.60s (0:14:09) ===========

@vijaysawant vijaysawant force-pushed the cu-case-manifest-reimport-failed branch from 0c3db5d to 5884d7a Compare April 1, 2024 08:50
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 1, 2024
damoore044
damoore044 reviewed Apr 1, 2024
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! Have some quick suggestions around the longer assertions on error messages, I would say nonblocking for these ..

tests/foreman/cli/test_subscription.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_subscription.py Show resolved Hide resolved
@vijaysawant vijaysawant force-pushed the cu-case-manifest-reimport-failed branch from 5884d7a to 01b8268 Compare April 2, 2024 09:00
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_subscription.py -k 'test_negative_check_katello_reimport'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6262
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_subscription.py -k test_negative_check_katello_reimport --external-logging
Test Result : =========== 1 passed, 10 deselected, 4 warnings in 754.45s (0:12:34) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 2, 2024
vsedmik
vsedmik reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments added

tests/foreman/cli/test_subscription.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_subscription.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_subscription.py Show resolved Hide resolved
@vijaysawant vijaysawant force-pushed the cu-case-manifest-reimport-failed branch from 01b8268 to 92d59e1 Compare April 2, 2024 11:41
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_subscription.py -k 'test_negative_check_katello_reimport'

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 2, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6266
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_subscription.py -k test_negative_check_katello_reimport --external-logging
Test Result : =========== 1 passed, 10 deselected, 4 warnings in 853.88s (0:14:13) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 2, 2024
@vijaysawant vijaysawant force-pushed the cu-case-manifest-reimport-failed branch from 92d59e1 to 7fbf263 Compare April 2, 2024 13:40
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 2, 2024
vsedmik
vsedmik approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damoore044 damoore044 merged commit 4cf63eb into SatelliteQE:master Apr 2, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 2, 2024
@vijaysawant @web-flow
cu-case-katello-reimport-scenario (#14572)
7810a66 
(cherry picked from commit 4cf63eb)
This was referenced Apr 2, 2024
Merged
Closed
@vijaysawant vijaysawant mentioned this pull request Apr 3, 2024
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@vijaysawant @shweta83
cu-case-katello-reimport-scenario (SatelliteQE#14572)
5721d6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damoore044 damoore044 damoore044 approved these changes

@vsedmik vsedmik vsedmik approved these changes

@jyejare jyejare jyejare approved these changes

Assignees

@vijaysawant vijaysawant

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vijaysawant @Satellite-QE @jyejare @vsedmik @damoore044