Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ansible API tests to Ansible-Cfgmgmt and REX classes #14626

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Move ansible API tests to Ansible-Cfgmgmt and REX classes #14626

merged 1 commit into from
Apr 5, 2024

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

Ansible tests are mixed in API ansible module, which need to be consistent as CLI/UI module

Solution

Move Ansible API tests to Ansible-ConfigurationManagement and Ansible-RemoteExecution classes, And few other minor fixes.

@Gauravtalreja1 Gauravtalreja1 added API Issues and PRs involving the API Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 4, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this Apr 4, 2024
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner April 4, 2024 14:23
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6315
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_ansible.py --external-logging
Test Result : ================ 12 passed, 1140 warnings in 4724.02s (1:18:44) ================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 4, 2024
Griffin-Sullivan
Griffin-Sullivan approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is hard to read so as long as your team is happy with the change I'm good to merge.

@Griffin-Sullivan
Copy link
Contributor

I guess it's easier to read https://github.com/SatelliteQE/robottelo/blob/0db0c68ff1b0dc7eb0a86cdde516cd37d978caf9/tests/foreman/api/test_ansible.py here

shubhamsg199
shubhamsg199 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@shubhamsg199 shubhamsg199 merged commit 4ad590a into SatelliteQE:master Apr 5, 2024
15 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
@Gauravtalreja1 @web-flow
Move ansible API tests to Ansible-Cfgmgmt and REX classes (#14626)
3dba6ae 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 4ad590a)
@Satellite-QE Satellite-QE mentioned this pull request Apr 5, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
@Gauravtalreja1 @web-flow
Move ansible API tests to Ansible-Cfgmgmt and REX classes (#14626)
f835999 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 4ad590a)
This was referenced Apr 5, 2024
Merged
Closed
@Gauravtalreja1 Gauravtalreja1 deleted the move-ansible-rex-api branch April 5, 2024 07:49
Gauravtalreja1 added a commit to Gauravtalreja1/robottelo that referenced this pull request Apr 5, 2024
@Gauravtalreja1
Move ansible API tests to Ansible-Cfgmgmt and REX classes (SatelliteQ…
de9010b 
…E#14626)

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 4ad590a)
@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Apr 5, 2024
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@Gauravtalreja1 @shweta83
Move ansible API tests to Ansible-Cfgmgmt and REX classes (SatelliteQ…
87d706a 
…E#14626)

Signed-off-by: Gaurav Talreja <[email protected]>
Gauravtalreja1 added a commit to Gauravtalreja1/robottelo that referenced this pull request Apr 11, 2024
@Gauravtalreja1
Move ansible API tests to Ansible-Cfgmgmt and REX classes (SatelliteQ…
2f4c23d 
…E#14626)

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 4ad590a)
omkarkhatavkar pushed a commit that referenced this pull request Apr 12, 2024
@Gauravtalreja1
[6.13.z] Move ansible API tests to Ansible-Cfgmgmt and REX classes (#…
3cdef79 
…14637)

Move ansible API tests to Ansible-Cfgmgmt and REX classes (#14626)

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 4ad590a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

@synkd synkd synkd approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 API Issues and PRs involving the API AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gauravtalreja1 @Satellite-QE @Griffin-Sullivan @synkd @shubhamsg199