Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TOTP generation. Fix what commit a5a5cd9e5e broke. #14645

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix TOTP generation. Fix what commit a5a5cd9e5e broke. #14645

merged 1 commit into from
May 7, 2024

Conversation

lhellebr
Copy link
Contributor

@lhellebr lhellebr commented Apr 5, 2024

No description provided.

@lhellebr lhellebr requested a review from a team as a code owner April 5, 2024 14:50
@lhellebr lhellebr added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 5, 2024
@lhellebr
Copy link
Contributor Author

lhellebr commented Apr 5, 2024

These PRs are unrelated but this PR will only work with all of them (there were multiple issues in the test):
#14645
SatelliteQE/airgun#1312
#14511
Internal commit updating TOTP secret.

@lhellebr lhellebr mentioned this pull request Apr 5, 2024
Merged
@shweta83
Copy link
Contributor

shweta83 commented Apr 8, 2024

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py -k test_totp_user_login
airgun: 1312

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6342
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py -k test_totp_user_login --external-logging
Test Result : ========== 1 failed, 28 deselected, 4 warnings in 2531.65s (0:42:11) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 8, 2024
@lhellebr
Copy link
Contributor Author

lhellebr commented Apr 8, 2024

As per my previous comment, PRT will fail.

@lhellebr lhellebr requested a review from a team April 15, 2024 16:06
@lhellebr
Copy link
Contributor Author

@SatelliteQE/robottelo-tier-2-reviewers

@lhellebr
Copy link
Contributor Author

Merge?

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py -k test_totp_user_login

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6729
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py -k test_totp_user_login --external-logging
Test Result : ========== 1 failed, 28 deselected, 45 warnings in 2635.71s (0:43:55) ==========

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py -k test_totp_user_login

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6736
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py -k test_totp_user_login --external-logging
Test Result : ========== 1 failed, 28 deselected, 45 warnings in 2395.03s (0:39:55) ==========

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py -k test_totp_user_login

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6740
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py -k test_totp_user_login --external-logging
Test Result : ========== 1 failed, 28 deselected, 45 warnings in 2230.74s (0:37:10) ==========

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py -k test_totp_user_login

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6744
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py -k test_totp_user_login --external-logging
Test Result : ========== 1 failed, 28 deselected, 45 warnings in 2266.64s (0:37:46) ==========

@lhellebr
Copy link
Contributor Author

lhellebr commented May 2, 2024

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py -k test_totp_user_login

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6770
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py -k test_totp_user_login --external-logging
Test Result : ========== 1 passed, 28 deselected, 45 warnings in 2279.61s (0:37:59) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 2, 2024
@lhellebr
Copy link
Contributor Author

lhellebr commented May 2, 2024

Dependencies have been merged, let's merge

@lhellebr
Copy link
Contributor Author

lhellebr commented May 6, 2024

It's been a month and there are no requests for changes. I'm gonna self-merge in a week from now unless somebody has objections.

@pondrejk pondrejk merged commit 50195ff into SatelliteQE:master May 7, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request May 7, 2024
@lhellebr @web-flow
Fix TOTP generation. Fix what commit a5a5cd9 broke. (#14645)
26ab7ed 
(cherry picked from commit 50195ff)
@Satellite-QE Satellite-QE mentioned this pull request May 7, 2024
Merged
lhellebr added a commit that referenced this pull request Jul 12, 2024
@lhellebr
Fix TOTP generation. Fix what commit a5a5cd9 broke. (#14645)
4f37fc0 
(cherry picked from commit 50195ff)
Gauravtalreja1 pushed a commit that referenced this pull request Jul 12, 2024
@Satellite-QE @lhellebr
[6.15.z] Fix TOTP generation. Fix what commit a5a5cd9 broke. (#14988)
4c13e57 
Fix TOTP generation. Fix what commit a5a5cd9 broke. (#14645)

(cherry picked from commit 50195ff)

Co-authored-by: Lukáš Hellebrandt <[email protected]>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@lhellebr @jyejare
Fix TOTP generation. Fix what commit a5a5cd9 broke. (SatelliteQE#14645)
1deecfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk pondrejk approved these changes

Assignees

@lhellebr lhellebr

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lhellebr @shweta83 @Satellite-QE @pondrejk