Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Proxy UI fixes #14646

Merged
merged 2 commits into from
Apr 8, 2024
Merged

HTTP Proxy UI fixes #14646

merged 2 commits into from
Apr 8, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Apr 5, 2024

Proposed changes

Just two fixes and one extension to address the component eval goals.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_http_proxy.py
airgun: 1311

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 5, 2024
@vsedmik vsedmik self-assigned this Apr 5, 2024
@vsedmik vsedmik requested a review from a team as a code owner April 5, 2024 15:02
@vsedmik
Copy link
Contributor Author

vsedmik commented Apr 5, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_http_proxy.py
airgun: 1311

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6327
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_http_proxy.py --external-logging
Test Result : ================= 8 passed, 190 warnings in 1965.12s (0:32:45) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 5, 2024
@vsedmik vsedmik mentioned this pull request Apr 5, 2024
Merged
pondrejk
pondrejk approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@pondrejk pondrejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending the existing suggestions

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 8, 2024
@shweta83
Copy link
Contributor

shweta83 commented Apr 8, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_http_proxy.py
airgun: 1311

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6340
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_http_proxy.py --external-logging
Test Result : ================= 8 passed, 189 warnings in 1988.24s (0:33:08) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 8, 2024
@jameerpathan111 jameerpathan111 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Apr 8, 2024
@jameerpathan111 jameerpathan111 merged commit f1799c9 into SatelliteQE:master Apr 8, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
@vsedmik @web-flow
HTTP Proxy UI fixes (#14646)
07a8cfb 
* HTTP Proxy UI fixes

* Docstring fix

(cherry picked from commit f1799c9)
@Satellite-QE Satellite-QE mentioned this pull request Apr 8, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
@vsedmik @web-flow
HTTP Proxy UI fixes (#14646)
36a3c9f 
* HTTP Proxy UI fixes

* Docstring fix

(cherry picked from commit f1799c9)
@Satellite-QE Satellite-QE mentioned this pull request Apr 8, 2024
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@vsedmik @shweta83
HTTP Proxy UI fixes (SatelliteQE#14646)
2e5d8ab 
* HTTP Proxy UI fixes

* Docstring fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shweta83 shweta83 shweta83 approved these changes

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@vsedmik vsedmik

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsedmik @Satellite-QE @shweta83 @pondrejk @jameerpathan111