Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage of BZ#2245081 ansible callback on capsule #14658

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Coverage of BZ#2245081 ansible callback on capsule #14658

merged 1 commit into from
Apr 10, 2024

Conversation

lpramuk
Copy link
Contributor

@lpramuk lpramuk commented Apr 8, 2024 •
edited
Loading

Problem Statement

Solution

Adding coverage of BZ#2245081 ansible callback on capsule that was delivered in 6.15.0

Related Issues

Merge #14692 and #14693 first please

SAT-24477

@lpramuk lpramuk added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 8, 2024
@lpramuk lpramuk self-assigned this Apr 8, 2024
@lpramuk lpramuk requested review from a team as code owners April 8, 2024 05:45
@lpramuk
Copy link
Contributor Author

lpramuk commented Apr 8, 2024

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py::test_installer_capsule_with_enabled_ansible

@lpramuk lpramuk force-pushed the cc_capsule_ansible_callback branch from ea1e49c to d341aec Compare April 8, 2024 06:02
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6334
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/installer/test_installer.py::test_installer_capsule_with_enabled_ansible --external-logging
Test Result : ================== 1 passed, 4 warnings in 1597.97s (0:26:37) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 8, 2024
@lpramuk lpramuk force-pushed the cc_capsule_ansible_callback branch from d341aec to bf00376 Compare April 8, 2024 06:32
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 8, 2024
@lpramuk lpramuk force-pushed the cc_capsule_ansible_callback branch from bf00376 to 0ca8021 Compare April 8, 2024 06:44
lpramuk
lpramuk commented Apr 8, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@lpramuk lpramuk added the QETestCoverage Issues and PRs relating to a Satellite bug label Apr 8, 2024
rmynar
rmynar approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@rmynar rmynar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider raising a separate PR for the ruff version bump. The rest is ACK.

@lpramuk
Copy link
Contributor Author

lpramuk commented Apr 8, 2024

I would consider raising a separate PR for the ruff version bump. The rest is ACK.

I can't - otherwise I am not getting green python 3.1x pipelines on this PR

@jyejare jyejare force-pushed the cc_capsule_ansible_callback branch from 0ca8021 to 51ef9f6 Compare April 8, 2024 13:52
@lpramuk lpramuk force-pushed the cc_capsule_ansible_callback branch 2 times, most recently from 84c1056 to 4b4bba6 Compare April 9, 2024 10:45
@lpramuk
Copy link
Contributor Author

lpramuk commented Apr 9, 2024

I would consider raising a separate PR for the ruff version bump. The rest is ACK.

Here you go - #14692

@jyejare jyejare force-pushed the cc_capsule_ansible_callback branch from 4b4bba6 to 7d869b0 Compare April 10, 2024 08:21
@jyejare
Copy link
Member

jyejare commented Apr 10, 2024

@lpramuk Rebased for pre-commit-config merged from another PR.

@lpramuk lpramuk force-pushed the cc_capsule_ansible_callback branch from 7d869b0 to 6514066 Compare April 10, 2024 08:44
@lpramuk lpramuk force-pushed the cc_capsule_ansible_callback branch from 6514066 to 3d261b5 Compare April 10, 2024 11:37
@lpramuk
Copy link
Contributor Author

lpramuk commented Apr 10, 2024

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py::test_installer_capsule_with_enabled_ansible

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6416
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/installer/test_installer.py::test_installer_capsule_with_enabled_ansible --external-logging
Test Result : ================= 1 passed, 13 warnings in 1528.64s (0:25:28) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 10, 2024
@Griffin-Sullivan Griffin-Sullivan merged commit 807365a into SatelliteQE:master Apr 10, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
@lpramuk @web-flow
Coverage of BZ#2245081 ansible callback on capsule (#14658)
b33def3 
(cherry picked from commit 807365a)
@Satellite-QE Satellite-QE mentioned this pull request Apr 10, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@lpramuk @jyejare
Coverage of BZ#2245081 ansible callback on capsule (SatelliteQE#14658)
c4a3dd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmynar rmynar rmynar approved these changes

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

@ogajduse ogajduse ogajduse approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@lpramuk lpramuk

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lpramuk @Satellite-QE @jyejare @pondrejk @ogajduse @Griffin-Sullivan @rmynar