Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRPM removal, SRPM fix #14675

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Apr 8, 2024

Problem Statement

Delta RPMs are not supported in Pulp and Satellite for quite a long time and related tests are being skipped for three and half years, as well as some SRPM tests, which are still supported though.

Solution

Remove the DRPM tests and fix the SRPM ones (they used puppet env instead of LCE).

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py::TestSRPMRepository

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 8, 2024
@vsedmik vsedmik requested a review from pnovotny April 8, 2024 13:57
@vsedmik vsedmik self-assigned this Apr 8, 2024
@vsedmik vsedmik requested review from a team as code owners April 8, 2024 13:57
@vsedmik
Copy link
Contributor Author

vsedmik commented Apr 8, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py::TestSRPMRepository

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6356
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_repository.py::TestSRPMRepository --external-logging
Test Result : ================== 2 passed, 39 warnings in 769.77s (0:12:49) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 8, 2024
@ColeHiggins2
Copy link
Member

does this need to be cherrypicked to earlier version too? @vsedmik

@vsedmik
Copy link
Contributor Author

vsedmik commented Apr 8, 2024

does this need to be cherrypicked to earlier version too? @vsedmik

Probably not necessarily, but I proposed 6.15 + 6.14 CPs just for the sake of the SRPM fix.

Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, merge pending on the question

@Gauravtalreja1 Gauravtalreja1 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Apr 8, 2024
Copy link
Contributor

@pnovotny pnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 9, 2024
@Gauravtalreja1 Gauravtalreja1 enabled auto-merge (squash) April 9, 2024 07:20
@Gauravtalreja1 Gauravtalreja1 added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 9, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit 0cf4cc6 into SatelliteQE:master Apr 9, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
* Get rid of deprecated DRPM repo tests

* Fix SRPM repo tests

(cherry picked from commit 0cf4cc6)
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
* Get rid of deprecated DRPM repo tests

* Fix SRPM repo tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants