CV Eval - Deletion #14678
CV Eval - Deletion #14678
Conversation
sambible
added
AutoMerge_Cherry_Picked
sambible
added
CherryPick
I tried bringing this problem up in a call once and I don't think I got the point across. I imagine this is an issue we will need to find a good solution for whether it's automated or a new process for the team each time we branch. |
There was a problem hiding this comment.
Looked over 2 files only
api/test_contentview.py & test_contentviewfilter.py
query for @sambible
| assert self.yumcv.repository[0].read().name == REPOS['rhst7']['name'] | ||
|
|
||
| @pytest.mark.tier2 | ||
| def test_positive_add_rh_custom_spin(self, target_sat): |
There was a problem hiding this comment.
Is this test consider by mistake, I don't see any recommendation in sheet.
There was a problem hiding this comment.
just added it back.
| @@ -788,78 +788,6 @@ def test_negative_update_with_name(self, new_name, content_view, module_target_s | |||
| {'content-view-id': content_view['id'], 'name': new_name} | |||
| ) | |||
|
|
|||
| @pytest.mark.tier1 | |||
| def test_negative_update_with_same_name(self, module_org, content_view, module_target_sat): | |||
There was a problem hiding this comment.
I believe this deletion must be due to low severity of test, don't see any qe-recommendation in the sheet.
There was a problem hiding this comment.
marked as QE delete
| ) | ||
|
|
||
| @pytest.mark.tier1 | ||
| def test_negative_update_inclusion(self, module_org, content_view, module_target_sat): |
There was a problem hiding this comment.
I believe this deletion must be due to low severity of test, don't see any qe-recommendation in the sheet.
There was a problem hiding this comment.
also listed as delete on sheet
| @@ -282,22 +254,6 @@ def test_positive_add_sha512_rpm(self, content_view, module_org, module_target_s | |||
| class TestContentViewCreate: | |||
| """Create tests for content views.""" | |||
|
|
|||
| @pytest.mark.parametrize('composite', [True, False]) | |||
| @pytest.mark.tier1 | |||
| def test_positive_create_composite(self, composite, target_sat): | |||
There was a problem hiding this comment.
In the eval spreadsheet I can see removal for all - api, cli and ui - but I don't see removal from UI here.
Did we miss it or was it intetional?
| @@ -369,43 +327,6 @@ def test_positive_add_synced_docker_repo(self, module_org, module_product, modul | |||
| content_view = content_view.update(['repository']) | |||
| assert repo.id in [repo_.id for repo_ in content_view.repository] | |||
|
|
|||
| @pytest.mark.tier2 | |||
| def test_positive_add_docker_repo_to_ccv(self, module_org, module_target_sat): | |||
There was a problem hiding this comment.
Similar here, in the eval sheet I can see the UI counterpart for removal too, but it's missing in this PR.
| def test_positive_publish_multiple_with_docker_repo(self, content_view, module_target_sat): | ||
| """Add Docker-type repository to content view and publish it multiple | ||
| times. | ||
|
|
||
| :id: 33c1b2ee-ae8a-4a7e-8254-123d97aaaa58 | ||
|
|
||
| :expectedresults: One repository is created with a Docker upstream | ||
| repository and the product is added to a content view which is then | ||
| published multiple times. | ||
| """ | ||
| assert len(content_view['versions']) == 0 | ||
|
|
||
| publish_amount = randint(2, 5) | ||
| for _ in range(publish_amount): | ||
| module_target_sat.cli.ContentView.publish({'id': content_view['id']}) | ||
| content_view = module_target_sat.cli.ContentView.info({'id': content_view['id']}) | ||
| assert len(content_view['versions']) == publish_amount | ||
|
|
||
| @pytest.mark.tier2 | ||
| def test_positive_publish_multiple_with_docker_repo_composite( |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yea, I'm removing the whole file in another PR
* Deleting all test cases marked as such in CV Eval * Add back mistakenly removed test * Remove unnecessary imports
Big PR here, lots of removals. This is deleting all cases marked as such as part of the CV Component Eval.
If you'd like to, you can review the cases deleted in the Pheonix Component Feedback sheet. The primary reason for deletion for a case is either