Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] notifications: no long tasks email for certain users #14699

Merged
merged 1 commit into from
Apr 9, 2024
Merged

[6.15.z] notifications: no long tasks email for certain users #14699

merged 1 commit into from
Apr 9, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14674

Problem Statement

Users with disabled account or disabled email were still receiving notifications about long-running tasks.

Solution

New test that verifies that these users don't receive the notification.

Related Issues

Bugzilla: https://bugzilla.redhat.com/2245056

@pnovotny @web-flow
notifications: no long tasks email for certain users (#14674)
f848b96 
notifications: exclude some users from long-running tasks email

Bugzilla: https://bugzilla.redhat.com/2245056

Verify that users with disabled account or disabled email don't receive
email notifications about long-running tasks.

(cherry picked from commit ce6777c)
@Satellite-QE Satellite-QE requested a review from a team as a code owner April 9, 2024 13:59
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Apr 9, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_notifications.py -k test_negative_no_notification_for_long_running_tasks

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Apr 9, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6397
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_notifications.py -k test_negative_no_notification_for_long_running_tasks --external-logging
Test Result : ========== 2 passed, 3 deselected, 31 warnings in 1024.04s (0:17:04) ===========

@Satellite-QE Satellite-QE merged commit 3193430 into 6.15.z Apr 9, 2024
15 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.15.z-ce6777ccb748227e8fba884a4a4df9c7b1ddaa2b branch April 9, 2024 14:23
@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnovotny pnovotny

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @pnovotny