Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix teardown of bootdisk tests with request.addfinalizer #14701

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fix teardown of bootdisk tests with request.addfinalizer #14701

merged 1 commit into from
Apr 10, 2024

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

If first test for rhel7 fails, rhel8 and rhel9 fails as well with error as media path is already taken

Solution

Use request.addfinalizer for teardown to delete media and hosts in bootdisk tests

Related Issues

@Gauravtalreja1 Gauravtalreja1 added CLI Issues and PRs involving the CLI TestFailure Issues and PRs related to a test failing in automation Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 9, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this Apr 9, 2024
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner April 9, 2024 14:15
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_bootdisk.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6398
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_bootdisk.py --external-logging
Test Result : ================== 3 passed, 67 warnings in 872.23s (0:14:32) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 9, 2024
shubhamsg199
shubhamsg199 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@shubhamsg199 shubhamsg199 merged commit a13c05d into SatelliteQE:master Apr 10, 2024
15 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
@Gauravtalreja1 @web-flow
Fix teardown of bootdisk tests with request.addfinalizer (#14701)
a5dd20a 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit a13c05d)
@Satellite-QE Satellite-QE mentioned this pull request Apr 10, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
@Gauravtalreja1 @web-flow
Fix teardown of bootdisk tests with request.addfinalizer (#14701)
2d74771 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit a13c05d)
@Satellite-QE Satellite-QE mentioned this pull request Apr 10, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
@Gauravtalreja1 @web-flow
Fix teardown of bootdisk tests with request.addfinalizer (#14701)
e9a1db1 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit a13c05d)
@Satellite-QE Satellite-QE mentioned this pull request Apr 10, 2024
Merged
@Gauravtalreja1 Gauravtalreja1 deleted the fix-teardown-bootdisk branch April 10, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches CLI Issues and PRs involving the CLI Easy Fix :) Easiest Fix to review and quick merge request. PRT-Passed Indicates that latest PRT run is passed for the PR TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gauravtalreja1 @Satellite-QE @shubhamsg199