Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark UI tests as end-to-end for Rocket Team Components #14702

Merged
merged 1 commit into from
May 8, 2024
Merged

Mark UI tests as end-to-end for Rocket Team Components #14702

merged 1 commit into from
May 8, 2024

Conversation

shweta83
Copy link
Contributor

@shweta83 shweta83 commented Apr 9, 2024 •
edited
Loading

Problem Statement

Some of the rocket team components missing e2e markers for UI tests.

Solution

Add the marker which were covering end-to-end scenarios of the respective components.

Related Issues

@shweta83 shweta83 requested a review from a team as a code owner April 9, 2024 14:25
@shweta83 shweta83 self-assigned this Apr 9, 2024
@shweta83 shweta83 marked this pull request as draft April 9, 2024 14:25
@shweta83 shweta83 force-pushed the ui_e2e_test_mark branch 3 times, most recently from 2b3d97a to 6fb17ba Compare April 22, 2024 19:01
@shweta83 shweta83 marked this pull request as ready for review April 22, 2024 19:02
@shweta83 shweta83 added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing labels Apr 22, 2024
@jameerpathan111
Copy link
Contributor

@shweta83 The PR branch needs rebasing

@shweta83 shweta83 force-pushed the ui_e2e_test_mark branch 2 times, most recently from e20cc6b to 0eb3df9 Compare April 29, 2024 18:14
Gauravtalreja1
Gauravtalreja1 reviewed Apr 29, 2024
View reviewed changes
tests/foreman/ui/test_computeresource.py
@@ -47,7 +47,7 @@ def rhev_data():


@pytest.mark.tier2
def test_positive_end_to_end(session, rhev_data, module_org, module_location, module_target_sat):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing the use of module_org, module_location here, why not consider using it to verify CR creation into specific org and location rather than default org/location?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any changes to the code is not the scope of this PR. I would rather make this update in separate PR. I have removed only those fixtures which are not used in the test.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, right, but you're modifying the existing usage of fixtures, which is also not in scope of the fixtures :)
so I'd recommend either using module_org, module_location here instead of removing this fixture use OR we can remove this change from this PR itself to avoid code modification

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not modifying any usage of fixtures, I am just removing the unused fixtures from the test.

@shweta83 shweta83 requested a review from Gauravtalreja1 May 3, 2024 06:39
Gauravtalreja1
Gauravtalreja1 reviewed May 3, 2024
View reviewed changes
tests/foreman/ui/test_computeresource_ec2.py
@@ -39,6 +39,7 @@ def module_ec2_settings():
)


@pytest.mark.e2e
@pytest.mark.tier2
@pytest.mark.skip_if_not_set('http_proxy')
@pytest.mark.skip_if_open("BZ:2032530")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this skip_if_open("BZ:2032530"), as its already closed as wontfix since long

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to modify/update the test to make it work. I would remove this once we update the test.

@Gauravtalreja1
Copy link
Collaborator

@shweta83 Could you please run the PRT with --team Rocket -m e2e to verify all of this tests pass after you update this PR?

@Gauravtalreja1 Gauravtalreja1 added 6.14.z Introduced in or relating directly to Satellite 6.14 and removed 6.12.z Introduced in or relating directly to Satellite 6.12 labels May 3, 2024
@shweta83
Copy link
Contributor Author

shweta83 commented May 6, 2024

--team Rocket -m e2e

This can be tested on CI. We are just adding e2e on the tests.

@shweta83 shweta83 requested a review from Gauravtalreja1 May 6, 2024 07:28
@shweta83 shweta83 force-pushed the ui_e2e_test_mark branch 2 times, most recently from 8fee578 to 219ae90 Compare May 6, 2024 09:59
@shweta83
Copy link
Contributor Author

shweta83 commented May 6, 2024

trigger: test-robottelo
pytest: tests/foreman/ui --team Rocket -m e2e

1 similar comment
@shweta83
Copy link
Contributor Author

shweta83 commented May 7, 2024

trigger: test-robottelo
pytest: tests/foreman/ui --team Rocket -m e2e

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6811
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui --team Rocket -m e2e --external-logging
Test Result : = 8 failed, 21 passed, 1 skipped, 662 deselected, 1616 warnings in 15304.99s (4:15:04) =

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 7, 2024
@shweta83 shweta83 force-pushed the ui_e2e_test_mark branch from 219ae90 to a587d84 Compare May 7, 2024 19:11
@shweta83
Copy link
Contributor Author

shweta83 commented May 7, 2024

trigger: test-robottelo
pytest: tests/foreman/ui --team Rocket -m e2e

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6834
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui --team Rocket -m e2e --external-logging
Test Result : = 3 failed, 26 passed, 1 skipped, 662 deselected, 1628 warnings in 15229.39s (4:13:49) =

@shweta83
Copy link
Contributor Author

shweta83 commented May 8, 2024

The 3 test cases failing are unrelated to the changes:
tests.foreman.ui.test_discoveryrule.test_positive_crud_with_non_admin_user
tests.foreman.ui.test_discoveryrule.test_positive_end_to_end
tests.foreman.ui.test_provisioningtemplate.test_positive_end_to_end

@shweta83 shweta83 force-pushed the ui_e2e_test_mark branch from a587d84 to 6377836 Compare May 8, 2024 07:05
@Gauravtalreja1 Gauravtalreja1 merged commit b3aa364 into SatelliteQE:master May 8, 2024
8 checks passed
This was referenced May 8, 2024
Closed
Closed
Closed
shweta83 added a commit to shweta83/robottelo that referenced this pull request May 17, 2024
@shweta83
Mark UI tests as end-to-end for Rocket Team Components (SatelliteQE#1…
42e955c 
…4702)
shweta83 added a commit to shweta83/robottelo that referenced this pull request May 17, 2024
@shweta83
Mark UI tests as end-to-end for Rocket Team Components (SatelliteQE#1…
4504480 
…4702)
@shweta83 shweta83 mentioned this pull request May 17, 2024
Merged
shweta83 added a commit to shweta83/robottelo that referenced this pull request May 17, 2024
@shweta83
Mark UI tests as end-to-end for Rocket Team Components (SatelliteQE#1…
728d0d3 
…4702)
shweta83 added a commit to shweta83/robottelo that referenced this pull request May 29, 2024
@shweta83
Mark UI tests as end-to-end for Rocket Team Components (SatelliteQE#1…
9bd99a9 
…4702)
Gauravtalreja1 pushed a commit that referenced this pull request May 29, 2024
@shweta83
[6.15.z Cherrypick]Mark UI tests as end-to-end for Rocket Team Compon…
17a056d 
…ents (#15103)

Mark UI tests as end-to-end for Rocket Team Components (#14702)
shweta83 added a commit to shweta83/robottelo that referenced this pull request Jun 6, 2024
@shweta83
Mark UI tests as end-to-end for Rocket Team Components (SatelliteQE#1…
757197a 
…4702)
shweta83 added a commit to shweta83/robottelo that referenced this pull request Jun 6, 2024
@shweta83
Mark UI tests as end-to-end for Rocket Team Components (SatelliteQE#1…
400b50c 
…4702)
shweta83 added a commit to shweta83/robottelo that referenced this pull request Jun 6, 2024
@shweta83
Mark UI tests as end-to-end for Rocket Team Components (SatelliteQE#1…
9d6771e 
…4702)
@shweta83 shweta83 mentioned this pull request Jun 6, 2024
Merged
shweta83 added a commit to shweta83/robottelo that referenced this pull request Jun 6, 2024
@shweta83
Mark UI tests as end-to-end for Rocket Team Components (SatelliteQE#1…
5d1ed39 
…4702)
shweta83 added a commit to shweta83/robottelo that referenced this pull request Jun 6, 2024
@shweta83
Mark UI tests as end-to-end for Rocket Team Components (SatelliteQE#1…
ec69e00 
…4702)
Gauravtalreja1 pushed a commit that referenced this pull request Jun 6, 2024
@shweta83
[6.13.z] Mark UI tests as end-to-end for Rocket Team Components (#15337)
6ed1e63 
Mark UI tests as end-to-end for Rocket Team Components (#14702)
shweta83 added a commit to shweta83/robottelo that referenced this pull request Jun 11, 2024
@shweta83
Mark UI tests as end-to-end for Rocket Team Components (SatelliteQE#1…
34a2806 
…4702)
Gauravtalreja1 pushed a commit that referenced this pull request Jun 11, 2024
@shweta83
[6.14.z] Mark UI tests as end-to-end for Rocket Team Components (#15338)
d01af12 
Mark UI tests as end-to-end for Rocket Team Components (#14702)
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@shweta83 @jyejare
Mark UI tests as end-to-end for Rocket Team Components (SatelliteQE#1…
9ba67a2 
…4702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

Assignees

@shweta83 shweta83

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shweta83 @jameerpathan111 @Gauravtalreja1 @Satellite-QE