Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.13.z] Mark UI tests as end-to-end for Rocket Team Components #15337

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

shweta83
Copy link
Contributor

@shweta83 shweta83 commented Jun 6, 2024

Problem Statement

Manual cherrypick of #14702

Solution

Related Issues

@shweta83 shweta83 added the No-CherryPick PR doesnt need CherryPick to previous branches label Jun 6, 2024
@shweta83 shweta83 self-assigned this Jun 6, 2024
@shweta83
Copy link
Contributor Author

shweta83 commented Jun 6, 2024

trigger: test-robottelo
pytest: tests/foreman/ui --team Rocket -m e2e

@shweta83 shweta83 force-pushed the 613z_ui_e2e_test_mark branch from 400b50c to 9d6771e Compare June 6, 2024 06:00
@shweta83
Copy link
Contributor Author

shweta83 commented Jun 6, 2024

trigger: test-robottelo
pytest: tests/foreman/ui --team Rocket -m e2e

@shweta83 shweta83 force-pushed the 613z_ui_e2e_test_mark branch from 8a97680 to ec69e00 Compare June 6, 2024 06:32
@Gauravtalreja1 Gauravtalreja1 added the 6.13.z Introduced in or relating directly to Satellite 6.13 label Jun 6, 2024
@Gauravtalreja1 Gauravtalreja1 changed the title Mark UI tests as end-to-end for Rocket Team Components (#14702) [6.13.z] Mark UI tests as end-to-end for Rocket Team Components Jun 6, 2024
@Gauravtalreja1 Gauravtalreja1 added the Failed_AutoCherryPick Issue for failed/conflicted auto cherry pick of PRs label Jun 6, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7308
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui --team Rocket -m e2e --external-logging
Test Result : = 4 failed, 21 passed, 1 skipped, 621 deselected, 1598 warnings in 7741.69s (2:09:01) =

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 6, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit 6ed1e63 into SatelliteQE:6.13.z Jun 6, 2024
15 checks passed
@@ -49,7 +49,7 @@ def rhev_data():


@pytest.mark.tier2
def test_positive_end_to_end(session, rhev_data, module_org, module_location):
def test_positive_end_to_end(session, rhev_data, module_target_sat):
"""Perform end to end testing for compute resource RHEV.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shweta83 the test is using entities instead of module_target_sat.api. Also, it'd be better if we use module_target_sat.ui_session() here. Same suggestion for other tests in the module. It's probably the same in master branch, so I'll leave it to you to decide if it should be done in separate PR.

@@ -18,6 +18,7 @@
from robottelo.utils.datafactory import gen_string


@pytest.mark.e2e
@pytest.mark.tier2
def test_positive_end_to_end(session, module_org, module_location, target_sat):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def test_positive_end_to_end(session, module_org, module_location, target_sat):
def test_positive_end_to_end(session, module_org, module_location, module_target_sat):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 Failed_AutoCherryPick Issue for failed/conflicted auto cherry pick of PRs No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants