Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.13.z] Fix Capsule.install when used w/o kwargs #14713

Merged
merged 1 commit into from
Apr 10, 2024
Merged

[6.13.z] Fix Capsule.install when used w/o kwargs #14713

merged 1 commit into from
Apr 10, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14693

Problem Statement

Capsule.install() fails with TypeError: 'NoneType' object is not iterable when used w/o kwargs
Some contributors already introduced misplaced workaround for this Capsule.run_installer_arg()

Solution

Fix Capsule.install() instead of implementing yet another installer method Capsule.run_installer_arg()

Related Issues

@Satellite-QE Satellite-QE added 6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Apr 10, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_capsule.py::test_positive_update_capsule

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Apr 10, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6414
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_capsule.py::test_positive_update_capsule --external-logging
Test Result : ================= 1 passed, 13 warnings in 2484.59s (0:41:24) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 10, 2024
@Satellite-QE Satellite-QE merged commit ff78bb1 into 6.13.z Apr 10, 2024
16 of 17 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.13.z-d37f76c3c9b6be2a49922f960015e70c5aa68202 branch April 10, 2024 11:45
@jyejare jyejare added 6.12.z Introduced in or relating directly to Satellite 6.12 CherryPick PR needs CherryPick to previous branches and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lpramuk lpramuk

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @lpramuk @jyejare