Remove pre-commit GitHub Action from our CI/CQ #14717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogajduse
added
6.11.z
Gauravtalreja1
approved these changes
Apr 10, 2024
Gauravtalreja1
removed
the
6.11.z
This was referenced Apr 10, 2024
ogajduse
added a commit
to ogajduse/robottelo
that referenced
this pull request
Apr 10, 2024
(cherry picked from commit 4f5c857)
ogajduse
added a commit
to ogajduse/robottelo
that referenced
this pull request
Apr 10, 2024
(cherry picked from commit 4f5c857)
ogajduse
added a commit
to ogajduse/robottelo
that referenced
this pull request
Apr 10, 2024
(cherry picked from commit 4f5c857)
ogajduse
added a commit
to ogajduse/robottelo
that referenced
this pull request
Apr 10, 2024
(cherry picked from commit 4f5c857)
This was referenced Apr 10, 2024
Gauravtalreja1
pushed a commit
that referenced
this pull request
Apr 10, 2024
Gauravtalreja1
pushed a commit
that referenced
this pull request
Apr 10, 2024
Gauravtalreja1
pushed a commit
that referenced
this pull request
Apr 10, 2024
Gauravtalreja1
pushed a commit
that referenced
this pull request
Apr 10, 2024
|
@ogajduse I wonder we are removing pre-commit checks from pull request checks. Does pre-commit-ci suppose to ammend the commit to the PR for pre-commit auto-fixes ? |
It creates an extra commit. See the image of git commit tree visualization in the auto fixing pull requests section on the page that I linked in the PR description. |
jyejare
pushed a commit
to jyejare/robottelo
that referenced
this pull request
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
pre-commit.ci is enabled for robottelo repository, the GH Action that runs pre-commit is now redundant.
Solution
Remove the pre-commit GitHub Action from our CI/CQ workflow. Also disable PR autofix if pre-commit auto fixes files.