Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.14.z] notifications: no long tasks email for certain users #14718

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[6.14.z] notifications: no long tasks email for certain users #14718

merged 1 commit into from
Apr 11, 2024

Conversation

pnovotny
Copy link
Contributor

Cherrypick of PR: #14674

Problem Statement

Users with disabled account or disabled email were still receiving notifications about long-running tasks.

Solution

New test that verifies that these users don't receive the notification.

Related Issues

Bugzilla: https://bugzilla.redhat.com/2245056

@pnovotny pnovotny added the No-CherryPick PR doesnt need CherryPick to previous branches label Apr 10, 2024
@pnovotny pnovotny self-assigned this Apr 10, 2024
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_notifications.py -k test_negative_no_notification_for_long_running_tasks

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6418
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_notifications.py -k test_negative_no_notification_for_long_running_tasks --external-logging
Test Result : ========== 2 passed, 2 deselected, 38 warnings in 1008.62s (0:16:48) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 10, 2024
@pnovotny
notifications: exclude some users from long-running tasks email
a274dcd 
Bugzilla: https://bugzilla.redhat.com/2245056

Verify that users with disabled account or disabled email don't receive
email notifications about long-running tasks.
@pnovotny pnovotny force-pushed the cherry-pick-6.14.z-no-long-tasks-email-for-certain-users branch from a54b4d2 to a274dcd Compare April 10, 2024 13:32
@pnovotny
Copy link
Contributor Author

a274dcd - rebase only

@pnovotny pnovotny marked this pull request as ready for review April 10, 2024 13:33
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 10, 2024
@pnovotny pnovotny requested a review from pondrejk April 10, 2024 13:33
@pnovotny pnovotny mentioned this pull request Apr 10, 2024
Closed
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_notifications.py -k test_negative_no_notification_for_long_running_tasks

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6438
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_notifications.py -k test_negative_no_notification_for_long_running_tasks --external-logging
Test Result : ========== 2 passed, 2 deselected, 38 warnings in 1044.37s (0:17:24) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 10, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit bd0da55 into SatelliteQE:6.14.z Apr 11, 2024
15 checks passed
@pnovotny pnovotny deleted the cherry-pick-6.14.z-no-long-tasks-email-for-certain-users branch April 30, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@Griffin-Sullivan Griffin-Sullivan Awaiting requested review from Griffin-Sullivan

@pondrejk pondrejk Awaiting requested review from pondrejk

Assignees

@pnovotny pnovotny

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnovotny @Satellite-QE @Gauravtalreja1