Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Ensure correct finalizer order #14745

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[6.15.z] Ensure correct finalizer order #14745

merged 1 commit into from
Apr 11, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14620

Problem Statement

the host was not deleted before the hostgroup

see: pytest-dev/pytest#10023 (comment)

Solution

Execute host finalizer after hostgroup finalizer

Note

This should replace #14568

@dosas @web-flow
Ensure correct finalizer order (#14620)
d9ced49 
the host was not deleted before the hostgroup

see: pytest-dev/pytest#10023 (comment)
(cherry picked from commit 8eea8dc)
@Satellite-QE Satellite-QE requested a review from a team as a code owner April 11, 2024 15:04
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Apr 11, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_parameters.py

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Apr 11, 2024
@JacobCallahan JacobCallahan enabled auto-merge (squash) April 11, 2024 15:08
@JacobCallahan JacobCallahan merged commit 6f54acc into 6.15.z Apr 11, 2024
14 of 16 checks passed
@JacobCallahan JacobCallahan deleted the cherry-pick-6.15.z-8eea8dcb1399574be063701b467c199bdd9e2bbb branch April 11, 2024 15:14
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6461
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_parameters.py --external-logging
Test Result : ================== 1 passed, 9 warnings in 652.94s (0:10:52) ===================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCallahan JacobCallahan JacobCallahan approved these changes

Assignees

@dosas dosas

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @JacobCallahan @dosas