Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the sub-man status #14783

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Remove the sub-man status #14783

merged 1 commit into from
Apr 16, 2024

Conversation

shweta83
Copy link
Contributor

@shweta83 shweta83 commented Apr 16, 2024 •
edited
Loading

Problem Statement

We had subscription status code for 6.15 and older versions, with 6.16, SCA is enabled by default and subscription status code are no more valid. This PR removes the assertion to check the subscription code and subscription_status_label.

The second issue was with the registration test where I have updated the output format to json.

Solution

Fixes the tests failing with the above issues.

Related Issues

@shweta83 shweta83 requested a review from a team as a code owner April 16, 2024 08:35
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py

@jameerpathan111
Copy link
Contributor

@shweta83 Can you update the PR description as to why we're doing this change?

@jameerpathan111 jameerpathan111 self-requested a review April 16, 2024 08:58
@shweta83
Copy link
Contributor Author

@shweta83 Can you update the PR description as to why we're doing this change?

Yes. I am going to add the description.

@shweta83 shweta83 added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 16, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6513
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py --external-logging
Test Result : ================= 4 passed, 979 warnings in 7088.38s (1:58:08) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 16, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 75
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py --external-logging
Test Result : ================= 4 passed, 973 warnings in 7112.51s (1:58:32) =================

@shweta83 shweta83 added the TestFailure Issues and PRs related to a test failing in automation label Apr 16, 2024
shubhamsg199
shubhamsg199 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@shubhamsg199 shubhamsg199 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Apr 16, 2024
@shubhamsg199 shubhamsg199 merged commit e021d3c into SatelliteQE:master Apr 16, 2024
15 of 16 checks passed
This was referenced Apr 16, 2024
Closed
Closed
Closed
Closed
shweta83 added a commit to shweta83/robottelo that referenced this pull request Apr 17, 2024
@shweta83
Remove the sub-man status (SatelliteQE#14783)
a40665b
shweta83 added a commit to shweta83/robottelo that referenced this pull request Apr 17, 2024
@shweta83
Remove the sub-man status (SatelliteQE#14783)
0eb01e7
@shweta83 shweta83 mentioned this pull request Apr 17, 2024
Merged
jameerpathan111 pushed a commit that referenced this pull request Apr 17, 2024
@shweta83
6.15.z Cherrypick Test_Fixes_and_SCA_enbaled_manifest (#14796)
bb997d3 
Remove the sub-man status (#14783)
shweta83 added a commit to shweta83/robottelo that referenced this pull request Apr 17, 2024
@shweta83
Remove the sub-man status (SatelliteQE#14783)
242afce
shweta83 added a commit to shweta83/robottelo that referenced this pull request Apr 17, 2024
@shweta83
Remove the sub-man status (SatelliteQE#14783)
e98064b
@shweta83 shweta83 mentioned this pull request Apr 17, 2024
Merged
shweta83 added a commit to shweta83/robottelo that referenced this pull request Apr 17, 2024
@shweta83
Remove the sub-man status (SatelliteQE#14783)
bafedd7
@shweta83 shweta83 mentioned this pull request Apr 17, 2024
Merged
shweta83 added a commit to shweta83/robottelo that referenced this pull request Apr 17, 2024
@shweta83
Remove the sub-man status (SatelliteQE#14783)
0d9d8a7
shweta83 added a commit to shweta83/robottelo that referenced this pull request Apr 17, 2024
@shweta83
Remove the sub-man status (SatelliteQE#14783)
320db84
shweta83 added a commit to shweta83/robottelo that referenced this pull request Apr 17, 2024
@shweta83
Remove the sub-man status (SatelliteQE#14783)
89ed4a1
shweta83 added a commit to shweta83/robottelo that referenced this pull request Apr 17, 2024
@shweta83
Remove the sub-man status (SatelliteQE#14783)
33095f9
shubhamsg199 pushed a commit that referenced this pull request Apr 17, 2024
@shweta83
Remove the sub-man status (#14783) (#14798)
6946f10
shubhamsg199 pushed a commit that referenced this pull request Apr 17, 2024
@shweta83
Remove the sub-man status (#14783) (#14797)
a4b9f7c
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@shweta83 @jyejare
Remove the sub-man status (SatelliteQE#14783)
ee4f004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@pondrejk pondrejk pondrejk approved these changes

@jameerpathan111 jameerpathan111 Awaiting requested review from jameerpathan111

Assignees

@shweta83 shweta83

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shweta83 @jameerpathan111 @Satellite-QE @pondrejk @shubhamsg199