Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip SyncPlan tests to SCA #14784

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Flip SyncPlan tests to SCA #14784

merged 1 commit into from
Apr 16, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Apr 16, 2024

Problem Statement

Four SyncPlans tests are still using entitlement mode, which was deprecated and removed in 6.16. They need to be flipped to SCA mode.

Solution

This PR.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_syncplan.py tests/foreman/cli/test_syncplan.py -k 'synchronize_rh_product_past_sync_date or synchronize_rh_product_future_sync_date'

@vsedmik vsedmik added Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches labels Apr 16, 2024
@vsedmik vsedmik self-assigned this Apr 16, 2024
@vsedmik vsedmik requested a review from a team as a code owner April 16, 2024 09:10
@vsedmik
Copy link
Contributor Author

vsedmik commented Apr 16, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_syncplan.py tests/foreman/cli/test_syncplan.py -k 'synchronize_rh_product_past_sync_date or synchronize_rh_product_future_sync_date'

shweta83
shweta83 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@shweta83 shweta83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6515
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_syncplan.py tests/foreman/cli/test_syncplan.py -k synchronize_rh_product_past_sync_date or synchronize_rh_product_future_sync_date --external-logging
Test Result : ========= 4 passed, 195 deselected, 275 warnings in 1530.71s (0:25:30) =========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 16, 2024
LadislavVasina1
LadislavVasina1 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

vijaysawant
vijaysawant approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@vijaysawant vijaysawant merged commit 4b9be13 into SatelliteQE:master Apr 16, 2024
11 checks passed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@vsedmik @jyejare
Flip SyncPlan tests to SCA (SatelliteQE#14784)
7c330a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

@shweta83 shweta83 shweta83 approved these changes

@vijaysawant vijaysawant vijaysawant approved these changes

Assignees

@vsedmik vsedmik

Labels
Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsedmik @Satellite-QE @vijaysawant @shweta83 @LadislavVasina1