-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_positive_clone_backup #14803
Conversation
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK pending comment.
robottelo/hosts.py
Outdated
@@ -1739,7 +1739,7 @@ def cli(self): | |||
self._cli._configured = True | |||
return self._cli | |||
|
|||
def install_satellite_or_capsule_package(self): | |||
def install_satellite_or_capsule_package(self, install_package=True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If installing the package is optional then we should modify the name of this function as its made/sounds to install the package only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking the same but I'm having a hard time coming up with something new.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about optional_satellite_or_capsule_package_install
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the pr. I split the helper into install_satellite_or_capsule_package
and enable_satellite_or_capsule_module_for_rhel8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRT has passed last time so I'm not retriggering it again as the change was not destructive.
2256944
to
d4bcd1f
Compare
Problem Statement
test_positive_clone_backup
is failing withSatellite is already installed. Satellite-clone should be run on a clean RHEL machine.
error.Solution
Related Issues