Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_positive_clone_backup #14803

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

jameerpathan111
Copy link
Contributor

Problem Statement

  • test_positive_clone_backup is failing with Satellite is already installed. Satellite-clone should be run on a clean RHEL machine. error.

Solution

  • Only enable the Satellite module but do not install the package.

Related Issues

  • SAT-24576

@jameerpathan111 jameerpathan111 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Apr 17, 2024
@jameerpathan111 jameerpathan111 self-assigned this Apr 17, 2024
@jameerpathan111 jameerpathan111 requested review from a team as code owners April 17, 2024 11:15
@jameerpathan111
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_clone.py -k "test_positive_clone_backup[include_pulp-offline]"

Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending comment.

@@ -1739,7 +1739,7 @@ def cli(self):
self._cli._configured = True
return self._cli

def install_satellite_or_capsule_package(self):
def install_satellite_or_capsule_package(self, install_package=True):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If installing the package is optional then we should modify the name of this function as its made/sounds to install the package only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking the same but I'm having a hard time coming up with something new.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got any suggestions?

Copy link
Contributor Author

@jameerpathan111 jameerpathan111 Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about optional_satellite_or_capsule_package_install?

Copy link
Contributor Author

@jameerpathan111 jameerpathan111 Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the pr. I split the helper into install_satellite_or_capsule_package and enable_satellite_or_capsule_module_for_rhel8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRT has passed last time so I'm not retriggering it again as the change was not destructive.

@jyejare jyejare merged commit ed0c03a into SatelliteQE:master Apr 18, 2024
8 checks passed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants