Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stream] fixes for combined session failures, Errata UI #14822

Merged
merged 2 commits into from
May 1, 2024

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented Apr 17, 2024

Problem Statement

Initial PR #14773 raised by @LadislavVasina1, for 3 errata UI test fixes/updates.

  • troubleshoot PRT failures in combined session, running the 3 tests from above PR.

Error in setup for test_positive_check_errata_counts_by_type_on_host_details_page :

Locally have intermittently reproduced issue with the registered_contenthost UI fixture with adding repos to cv, and promotion of cv to lce, in between parameters of combined session. Issues with some associated activation keys not being deleted in cleanup.

^^ Issues fixed with 2nd commit.

PRT Case

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page or test_positive_list and not test_positive_list_permission'
  • We run the 3 impacted tests from @LadislavVasina1 's PR and commits,
    along with test_positive_list, which fails in CI and is fixed by the changes.
    We exclude the otherwise collected test_positive_list_permissions, it is not impacted by these changes.

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page'
airgun: 1337

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6580
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_errata.py -k test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page --external-logging
Test Result : ===== 2 passed, 13 deselected, 91 warnings, 1 error in 1154.36s (0:19:14) ======

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 17, 2024
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page'
airgun: 1337

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6587
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_errata.py -k test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page --external-logging
Test Result : ===== 3 passed, 13 deselected, 97 warnings, 2 errors in 1314.73s (0:21:54) =====

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page'
airgun: 1337

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py
airgun: 1337

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page'
airgun: 1337

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 113
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py -k test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page --external-logging
Test Result : ========= 3 passed, 13 deselected, 117 warnings in 1268.42s (0:21:08) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Apr 18, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6605
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py -k test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page --external-logging
Test Result : ========= 3 passed, 13 deselected, 118 warnings in 1371.90s (0:22:51) ==========

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page'

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 18, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 109
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_errata.py --external-logging
Test Result : ====== 8 failed, 7 passed, 1115 warnings, 5 errors in 5567.45s (1:32:47) =======

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 18, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6601
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_errata.py --external-logging
Test Result : ====== 8 failed, 6 passed, 1120 warnings, 8 errors in 5874.49s (1:37:54) =======

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6606
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py -k test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page --external-logging
Test Result : ========= 3 passed, 13 deselected, 121 warnings in 1347.37s (0:22:27) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Apr 18, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 114
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py -k test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page --external-logging
Test Result : ========= 3 passed, 13 deselected, 122 warnings in 1480.89s (0:24:40) ==========

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 117
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_errata.py --external-logging
Test Result : ======= 7 failed, 8 passed, 1189 warnings, 1 error in 5660.16s (1:34:20) =======

@Satellite-QE Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Apr 18, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6609
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_errata.py --external-logging
Test Result : ======= 6 failed, 9 passed, 1194 warnings, 1 error in 5861.74s (1:37:41) =======

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6714
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py -k test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page or test_positive_list and not test_positive_list_permission --external-logging
Test Result : ========= 4 passed, 12 deselected, 167 warnings in 1510.77s (0:25:10) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 26, 2024
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page or test_positive_list and not test_positive_list_permission'

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 30, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6751
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py -k test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page or test_positive_list and not test_positive_list_permission --external-logging
Test Result : ========= 4 passed, 12 deselected, 166 warnings in 1417.19s (0:23:37) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 30, 2024
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix and a question

tests/foreman/ui/test_errata.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_errata.py Outdated Show resolved Hide resolved
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 1, 2024
@damoore044 damoore044 force-pushed the master branch 2 times, most recently from 9cb3ca3 to 20a7391 Compare May 1, 2024 15:13
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page or test_positive_list and not test_positive_list_permission'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6757
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py -k test_positive_check_errata or test_positive_errata_search_type or test_positive_check_errata_counts_by_type_on_host_details_page or test_positive_list and not test_positive_list_permission --external-logging
Test Result : ========= 4 passed, 12 deselected, 171 warnings in 1369.35s (0:22:49) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 1, 2024
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack pending griffin's comments.

@Griffin-Sullivan Griffin-Sullivan merged commit 9448d4b into SatelliteQE:master May 1, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request May 1, 2024
* Refactor and fix of some Errata UI tests

* UI fixture and other updates for combined sessions

---------

Co-authored-by: Ladislav Vasina <[email protected]>
(cherry picked from commit 9448d4b)
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
…14822)

* Refactor and fix of some Errata UI tests

* UI fixture and other updates for combined sessions

---------

Co-authored-by: Ladislav Vasina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants