Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.15.z update scope of fixtures from hosts-content longrun test_inc_updates #14843

Merged

Conversation

vijaysawant
Copy link
Contributor

@vijaysawant vijaysawant commented Apr 20, 2024

Problem Statement

longrun/test_inc_updates.py has 2 tests, module scope fixture creates one organization and same organization has been used in two test cases, after uploading manifest second time test was failing due to below error message

test name: test_positive_incremental_update_time
Error:
['Owner has already imported from another subscription management application. The following conflicts were found: [ DISTRIBUTOR_CONFLICT ]']

Solution

changed scope of fixture of one test case so it will not use previously created organization from same test session.

Related Issues

6.14.z PR #14842

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/longrun/test_inc_updates.py

@vijaysawant vijaysawant added No-CherryPick PR doesnt need CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 20, 2024
@vijaysawant vijaysawant requested a review from a team as a code owner April 20, 2024 15:15
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/longrun/test_inc_updates.py

@vijaysawant vijaysawant requested review from sambible, ColeHiggins2, vsedmik, synkd and damoore044 and removed request for a team April 20, 2024 15:18
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6627
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/longrun/test_inc_updates.py --external-logging
Test Result : ============ 1 passed, 108 warnings, 1 error in 1070.86s (0:17:50) =============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 20, 2024
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/longrun/test_inc_updates.py -k test_positive_noapply_api

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6628
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/longrun/test_inc_updates.py -k test_positive_noapply_api --external-logging
Test Result : ============ 1 deselected, 9 warnings, 1 error in 790.96s (0:13:10) ============

@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/longrun/test_inc_updates.py -k test_positive_incremental_update_time

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6629
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/longrun/test_inc_updates.py -k test_positive_incremental_update_time --external-logging
Test Result : =========== 1 passed, 1 deselected, 15 warnings in 999.88s (0:16:39) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Apr 20, 2024
@vijaysawant vijaysawant changed the title 6.15.z update fixtures name from test_inc_updates 6.15.z update scope of fixtures from hosts-content longrun test_inc_updates Apr 22, 2024
@vijaysawant vijaysawant marked this pull request as draft April 25, 2024 07:56
@vijaysawant vijaysawant force-pushed the 6.15.z-longrun-update-fixtures branch from bd48486 to b38d41b Compare April 25, 2024 09:41
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/longrun/test_inc_updates.py

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 25, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6684
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/longrun/test_inc_updates.py --external-logging
Test Result : ============ 1 passed, 105 warnings, 1 error in 1213.26s (0:20:13) =============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 25, 2024
@vijaysawant vijaysawant force-pushed the 6.15.z-longrun-update-fixtures branch from b38d41b to dcb6289 Compare April 25, 2024 10:18
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/longrun/test_inc_updates.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6686
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/longrun/test_inc_updates.py --external-logging
Test Result : ============ 1 passed, 113 warnings, 1 error in 1265.32s (0:21:05) =============

@vijaysawant
Copy link
Contributor Author

  • The reason of failing test is not related to this changes, it is failing inside setup contenthost
    failed on setup with "robottelo.hosts.ContentHostError: Failed to install katello-host-tools"
  • 6.14.z PRT passed for same changes.

@vijaysawant vijaysawant marked this pull request as ready for review April 25, 2024 14:53
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6705
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/longrun/test_inc_updates.py --external-logging
Test Result : ============ 1 passed, 106 warnings, 1 error in 1156.72s (0:19:16) =============

@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/longrun/test_inc_updates.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6709
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/longrun/test_inc_updates.py --external-logging
Test Result : ============ 1 passed, 106 warnings, 1 error in 1047.15s (0:17:27) =============

Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vijaysawant It seems the other test for this module you're trying to run also,
test_positive_noapply_api fails in the host fixture (@L134).

Trying to install katello-host-tools on a rhel7_contenthost_module fixture (outdated),
to get that one fixed we might want to change host fixture to use rhel_contenthost parameterized for rhel version, like with errata hosts?

But since you only changed org fixture for test_positive_noapply_api in these changes, probably non-blocking. Thoughts?

@vijaysawant
Copy link
Contributor Author

@vijaysawant It seems the other test for this module you're trying to run also, test_positive_noapply_api fails in the host fixture (@L134).

Trying to install katello-host-tools on a rhel7_contenthost_module fixture (outdated), to get that one fixed we might want to change host fixture to use rhel_contenthost parameterized for rhel version, like with errata hosts?

But since you only changed org fixture for test_positive_noapply_api in these changes, probably non-blocking. Thoughts?

It's not woking with rhel_contenthost (module_rhel_contenthost) as well, giving same error

> raise ContentHostError('Failed to install katello-host-tools') E robottelo.hosts.ContentHostError: Failed to install katello-host-tools

@damoore044
Copy link
Contributor

@vijaysawant Gotcha, we should also try to remove line in host fixture that installs katello host tools (deprecated).
Packages and support for katello-host-tools has been removed, you probably don't need that installed to the contenthost anymore.

Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack pending passing robottelo runner

@vsedmik vsedmik merged commit 077f8d9 into SatelliteQE:6.15.z May 6, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants