Extend search in *_default_os fixtures for EL9 as default OS #14851

Gauravtalreja1 · 2024-04-22T09:30:23Z

Problem Statement

When EL9 is default OS for Foreman, *_default_os fixtures returns below error

pytest_fixtures/component/os.py:24: in default_os
    os = entities.OperatingSystem().search(query={'search': search_string})[0].read()
E   IndexError: list index out of range

Solution

Add EL9 in search_string for *_default_os fixtures
Move default os search query to constants and delete unused session_default_os fixture (from review)

Related Issues

Signed-off-by: Gaurav Talreja <[email protected]>

Gauravtalreja1 · 2024-04-22T09:36:15Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_registration.py::test_positive_global_registration_end_to_end[rhel9]

Satellite-QE · 2024-04-22T10:00:29Z

PRT Result

Build Number: 6638
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_registration.py::test_positive_global_registration_end_to_end[rhel9] --external-logging
Test Result : ================= 1 passed, 15 warnings in 1104.39s (0:18:24) ==================

jameerpathan111 · 2024-04-22T10:01:31Z

pytest_fixtures/component/os.py

@@ -17,7 +17,7 @@ def default_os(
    """
    os = getattr(request, 'param', None)
    if os is None:
-        search_string = 'name="RedHat" AND (major="6" OR major="7" OR major="8")'
+        search_string = 'name="RedHat" AND (major="6" OR major="7" OR major="8" OR major="9")'


@Gauravtalreja1 maybe we should fix following occurrences too.

robottelo/tests/foreman/ui/test_contentview_old.py

Line 2679 in d13439e

query={'search': 'name="RedHat" AND (major="6" OR major="7")'}

robottelo/robottelo/host_helpers/api_factory.py

Line 339 in d13439e

.search(query={'search': 'name="RedHat" AND (major="6" OR major="7")'})[0]

OR we should add this query as a constant so we won't have to go through this in future, wdyt?

I wonder how tests from test_contentview_old is working even when Foreman is on EL8, and second one from api_factory helper is unused so its expected we missed it for EL8 earlier.

@jameerpathan111 Good point, about moving this search query as robottelo contant, so we can update this at single place when OS version changes. I've made the changes, request to re-review, Thank you!

…efault_os fixture Signed-off-by: Gaurav Talreja <[email protected]>

Gauravtalreja1 · 2024-04-22T10:58:59Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_registration.py::test_positive_global_registration_end_to_end[rhel9]

jyejare · 2024-04-22T11:04:42Z

pytest_fixtures/component/os.py

@@ -17,7 +19,7 @@ def default_os(
    """
    os = getattr(request, 'param', None)
    if os is None:
-        search_string = 'name="RedHat" AND (major="6" OR major="7" OR major="8")'
+        search_string = constants.DEFAULT_OS_SEARCH_QUERY


FYI, there is a discussion/PR in progress on how we retrieve the default OS.

We are to remove the need of search string especially for searching default os.

@jyejare I don't see much progress on the discussion there. Do we want to hold off on this PR/fix? Is someone already assigned to work on it?

@jameerpathan111 @Gauravtalreja1 can either choose to fix discussion/PR comment in this PR or merge this as is if its urgent.

Which we would you like to go ?

@jyejare I'd prefer getting this merged as it is as its urgent for automation many tests are failing due to this, and we can discuss this in JPL call later to make this dynamically configurable later which can be handled in separate PR

a ping would have been nice

@jyejare I don't see much progress on the discussion there. Do we want to hold off on this PR/fix? Is someone already assigned to work on it?

2 weeks ago there were two approvals and no answer from @lpramuk requested changes

Satellite-QE · 2024-04-22T11:28:28Z

PRT Result

Build Number: 6639
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_registration.py::test_positive_global_registration_end_to_end[rhel9] --external-logging
Test Result : ================= 1 passed, 15 warnings in 1160.57s (0:19:20) ==================

ogajduse · 2024-04-22T15:44:33Z

I would like to remind the audience of this PR that there is an open issue pointing to the need to add newly released versions to the list. My personal preference would be to address the issue rather than continue using the same pattern.
#10481

jameerpathan111 · 2024-04-24T14:05:45Z

I would like to remind the audience of this PR that there is an open issue pointing to the need to add newly released versions to the list. My personal preference would be to address the issue rather than continue using the same pattern. #10481

@Gauravtalreja1 what do you want to do? do you want to take up this task or go with your current approach?

…teQE#14851) * Extend search in *_default_os fixtures for EL9 as default OS Signed-off-by: Gaurav Talreja <[email protected]> * Move default os search query to constants and delete unused session_default_os fixture Signed-off-by: Gaurav Talreja <[email protected]> --------- Signed-off-by: Gaurav Talreja <[email protected]>

Extend search in *_default_os fixtures for EL9 as default OS

3fdd7e8

Signed-off-by: Gaurav Talreja <[email protected]>

Gauravtalreja1 added Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Apr 22, 2024

Gauravtalreja1 self-assigned this Apr 22, 2024

Gauravtalreja1 requested a review from a team as a code owner April 22, 2024 09:30

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 22, 2024

jameerpathan111 reviewed Apr 22, 2024

View reviewed changes

Move default os search query to constants and delete unused session_d…

0328b9a

…efault_os fixture Signed-off-by: Gaurav Talreja <[email protected]>

Gauravtalreja1 requested a review from a team as a code owner April 22, 2024 10:51

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 22, 2024

Gauravtalreja1 removed the Easy Fix :) Easiest Fix to review and quick merge request. label Apr 22, 2024

jyejare reviewed Apr 22, 2024

View reviewed changes

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 22, 2024

jameerpathan111 mentioned this pull request Apr 24, 2024

os fixtures updated for rhel9 #14876

Closed

jameerpathan111 approved these changes Apr 24, 2024

View reviewed changes

jameerpathan111 requested a review from jyejare April 24, 2024 15:54

pondrejk approved these changes Apr 25, 2024

View reviewed changes

pondrejk merged commit 7be34b0 into SatelliteQE:master Apr 25, 2024
11 of 12 checks passed

Gauravtalreja1 deleted the default-os-el9 branch April 26, 2024 07:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend search in *_default_os fixtures for EL9 as default OS #14851

Extend search in *_default_os fixtures for EL9 as default OS #14851

Gauravtalreja1 commented Apr 22, 2024 •

edited

Loading

Gauravtalreja1 commented Apr 22, 2024

Satellite-QE commented Apr 22, 2024

jameerpathan111 Apr 22, 2024

Gauravtalreja1 Apr 22, 2024

Gauravtalreja1 commented Apr 22, 2024

jyejare Apr 22, 2024

jameerpathan111 Apr 24, 2024

jyejare Apr 25, 2024

Gauravtalreja1 Apr 25, 2024 •

edited

Loading

dosas Apr 29, 2024

dosas Apr 29, 2024

Satellite-QE commented Apr 22, 2024

ogajduse commented Apr 22, 2024

jameerpathan111 commented Apr 24, 2024 •

edited

Loading

Extend search in *_default_os fixtures for EL9 as default OS #14851

Extend search in *_default_os fixtures for EL9 as default OS #14851

Conversation

Gauravtalreja1 commented Apr 22, 2024 • edited Loading

Problem Statement

Solution

Related Issues

Gauravtalreja1 commented Apr 22, 2024

Satellite-QE commented Apr 22, 2024

jameerpathan111 Apr 22, 2024

Choose a reason for hiding this comment

Gauravtalreja1 Apr 22, 2024

Choose a reason for hiding this comment

Gauravtalreja1 commented Apr 22, 2024

jyejare Apr 22, 2024

Choose a reason for hiding this comment

jameerpathan111 Apr 24, 2024

Choose a reason for hiding this comment

jyejare Apr 25, 2024

Choose a reason for hiding this comment

Gauravtalreja1 Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

dosas Apr 29, 2024

Choose a reason for hiding this comment

dosas Apr 29, 2024

Choose a reason for hiding this comment

Satellite-QE commented Apr 22, 2024

ogajduse commented Apr 22, 2024

jameerpathan111 commented Apr 24, 2024 • edited Loading

Gauravtalreja1 commented Apr 22, 2024 •

edited

Loading

Gauravtalreja1 Apr 25, 2024 •

edited

Loading

jameerpathan111 commented Apr 24, 2024 •

edited

Loading