Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templatesync test fixes #14860

Merged
merged 1 commit into from
May 20, 2024
Merged

templatesync test fixes #14860

merged 1 commit into from
May 20, 2024

Conversation

pondrejk
Copy link
Contributor

Problem Statement

paths seem to have changed, made some amendments

@pondrejk pondrejk added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 23, 2024
@pondrejk pondrejk self-assigned this Apr 23, 2024
@pondrejk pondrejk requested a review from a team as a code owner April 23, 2024 09:27
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_filtered_templates_to_git

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6648
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_filtered_templates_to_git --external-logging
Test Result : ============= 2 failed, 2 passed, 40 warnings in 731.58s (0:12:11) =============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 23, 2024
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_filtered_templates_to_git

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6650
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_filtered_templates_to_git --external-logging
Test Result : ============= 2 failed, 2 passed, 32 warnings in 681.94s (0:11:21) =============

@shweta83
Copy link
Contributor

shweta83 commented May 2, 2024

@pondrejk Can you please check the test failures?

@pondrejk
Copy link
Contributor Author

pondrejk commented May 7, 2024 •
edited
Loading

turns out there is an another issue to investigate that affects only empty-repo exports, this pr however does reduce the failures and is a prerequisite to fixing the mentioned problem, so I'm re-running prt with a different collection

@pondrejk
Copy link
Contributor Author

pondrejk commented May 7, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_templatesync.py -k test_positive_export_filtered_templates_to_git[non_empty_repo-ssh]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6820
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_templatesync.py -k test_positive_export_filtered_templates_to_git[non_empty_repo-ssh] --external-logging
Test Result : =========== 1 passed, 7 deselected, 16 warnings in 639.42s (0:10:39) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 7, 2024
vsedmik
vsedmik approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, PRT passed too

@vsedmik vsedmik merged commit 3d9d302 into SatelliteQE:master May 20, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request May 20, 2024
@pondrejk @web-flow
templatesync test fixes (#14860)
fcc877f 
(cherry picked from commit 3d9d302)
@Satellite-QE Satellite-QE mentioned this pull request May 20, 2024
Merged
pondrejk added a commit that referenced this pull request May 20, 2024
@Satellite-QE @pondrejk
[6.15.z] templatesync test fixes (#15111)
7e76ff7 
templatesync test fixes (#14860)

(cherry picked from commit 3d9d302)

Co-authored-by: Peter Ondrejka <[email protected]>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@pondrejk @jyejare
templatesync test fixes (SatelliteQE#14860)
dddc695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

Assignees

@pondrejk pondrejk

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pondrejk @Satellite-QE @shweta83 @vsedmik