Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timeout parameters added to cli create methods #14861

Merged
merged 1 commit into from
Apr 23, 2024
Merged

timeout parameters added to cli create methods #14861

merged 1 commit into from
Apr 23, 2024

Conversation

pondrejk
Copy link
Contributor

Problem Statement

#14437 didn't take into account other cli objects with custom create method, kudos to @vsedmik for spotting this

Solution

adding the timeout parameter

@pondrejk pondrejk added the No-CherryPick PR doesnt need CherryPick to previous branches label Apr 23, 2024
@pondrejk pondrejk self-assigned this Apr 23, 2024
@pondrejk pondrejk requested a review from a team as a code owner April 23, 2024 11:22
@pondrejk pondrejk requested a review from vsedmik April 23, 2024 11:22
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_webhook.py -k test_webhook_disabled_enabled

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_repository.py -k test_positive_create_with_name_label[2]

@pondrejk pondrejk added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Apr 23, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6651
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_webhook.py -k test_webhook_disabled_enabled --external-logging
Test Result : =========== 1 passed, 2 deselected, 11 warnings in 697.42s (0:11:37) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 23, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6652
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_repository.py -k test_positive_create_with_name_label[2] --external-logging
Test Result : ========= 1 passed, 139 deselected, 148 warnings in 768.27s (0:12:48) ==========

@pondrejk pondrejk merged commit e8c1ed9 into SatelliteQE:master Apr 23, 2024
14 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
@pondrejk @web-flow
timeout parameters added to cli create methods (#14861)
764c72f 
(cherry picked from commit e8c1ed9)
@Satellite-QE Satellite-QE mentioned this pull request Apr 23, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@pondrejk @jyejare
timeout parameters added to cli create methods (SatelliteQE#14861)
865e1e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

Assignees

@pondrejk pondrejk

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pondrejk @Satellite-QE @vsedmik