Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.14.z] Add proper teardown of VMware client #14863

Merged
merged 1 commit into from
Apr 23, 2024
Merged

[6.14.z] Add proper teardown of VMware client #14863

merged 1 commit into from
Apr 23, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14799

Problem Statement

There wasn't any proper teardown of vmwareclient. we see DEBUG - vCenter keep-alive: 2024-04-14 07:51:45.515419+00:00 in the logs

Solution

Add a fixture which handles the proper teardown

@shubhamsg199 @web-flow
Add proper teardown of VMware client (#14799)
9349023 
Proper teardown of VMwar client

Signed-off-by: Shubham Ganar <[email protected]>
(cherry picked from commit 9de3979)
@Satellite-QE Satellite-QE added 6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Apr 23, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Apr 23, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6656
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end --external-logging
Test Result : ========== 2 passed, 10 deselected, 66 warnings in 8633.51s (2:23:53) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 23, 2024
@Satellite-QE Satellite-QE merged commit 0296d3e into 6.14.z Apr 23, 2024
17 of 18 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.14.z-9de39799d311e7ae783a4a35f3ae873b626cc6ba branch April 23, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

Assignees

@shubhamsg199 shubhamsg199

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @jameerpathan111 @shubhamsg199