Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CaseAutomation for tests and delete Certificates related tests as part of component audit. #14873

Merged

Conversation

jameerpathan111
Copy link
Contributor

This PR

  • Deletes certificate-related tests as part of the component audit.
  • Fixes CaseAutomation, as some of the tests are marked as NotAutomated even though they are automated and should be run in automation.

Related Issues

  • SAT-23021

@jameerpathan111 jameerpathan111 added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 24, 2024
@jameerpathan111 jameerpathan111 self-assigned this Apr 24, 2024
@jameerpathan111 jameerpathan111 requested a review from a team as a code owner April 24, 2024 09:12
@@ -2,7 +2,7 @@

:Requirement: Provisioning

:CaseAutomation: NotAutomated
:CaseAutomation: Automated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shweta83 can you confirm this change for Team Rocket?

@jameerpathan111 jameerpathan111 force-pushed the certificates_delete branch 3 times, most recently from 22ecff1 to 3f2a24b Compare April 24, 2024 09:31
@@ -220,6 +224,7 @@ def test_pre_default_role_added_permission_with_filter(self, target_sat):
:expectedresults: Permission with filter is added to existing
'Default role'

:CaseAutomation: Automated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pondrejk can you confirm this change for Team Endeavour?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jameerpathan111 Can we update :CaseAutomation: Automated at top and mark stubbed tests as NotAutomated instead, like we do in other tests module?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, I went with both;)

@jameerpathan111 jameerpathan111 force-pushed the certificates_delete branch 2 times, most recently from 714a897 to 5a07469 Compare April 25, 2024 14:13
Copy link
Contributor

@shweta83 shweta83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack for Rocket team components.
Please address rest of the review comments.

@Gauravtalreja1 Gauravtalreja1 merged commit eef3b2d into SatelliteQE:master Apr 26, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
… part of component audit. (#14873)

Delete Certificates related tests as part of component refactor task

(cherry picked from commit eef3b2d)
github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
… part of component audit. (#14873)

Delete Certificates related tests as part of component refactor task

(cherry picked from commit eef3b2d)
github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
… part of component audit. (#14873)

Delete Certificates related tests as part of component refactor task

(cherry picked from commit eef3b2d)
Gauravtalreja1 pushed a commit that referenced this pull request Apr 26, 2024
… tests as part of component audit. (#14902)

Fix CaseAutomation for tests and delete Certificates related tests as part of component audit. (#14873)

Delete Certificates related tests as part of component refactor task

(cherry picked from commit eef3b2d)

Co-authored-by: Jameer Pathan <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Apr 26, 2024
… tests as part of component audit. (#14903)

Fix CaseAutomation for tests and delete Certificates related tests as part of component audit. (#14873)

Delete Certificates related tests as part of component refactor task

(cherry picked from commit eef3b2d)

Co-authored-by: Jameer Pathan <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Apr 26, 2024
… tests as part of component audit. (#14904)

Fix CaseAutomation for tests and delete Certificates related tests as part of component audit. (#14873)

Delete Certificates related tests as part of component refactor task

(cherry picked from commit eef3b2d)

Co-authored-by: Jameer Pathan <[email protected]>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
… part of component audit. (SatelliteQE#14873)

Delete Certificates related tests as part of component refactor task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants