Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.14.z-fix keyError: 'rhel8 + _bos' from api>tests_repository.py #14875

Conversation

vijaysawant
Copy link
Contributor

Problem Statement

During TFA, found test test_positive_sync_kickstart_check_os was failing due to error below
KeyError: 'rhel8 + "_bos"' and KeyError: 'rhel9 + "_bos"'

Solution

Along with small change in failed test, make changes in robottelo constants keys for REPOSET>kickstart>distro from
rhel8 to rhel8_bos
rhel9 to rhel9_bos

Related Issues

N/A

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py -k 'test_positive_sync_kickstart_check_os'

trigger: test-robottelo
pytest: tests/foreman/cli/test_repositories.py -k 'test_positive_disable_rh_repo_with_basearch'

@vijaysawant vijaysawant added TestFailure Issues and PRs related to a test failing in automation Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 labels Apr 24, 2024
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py -k 'test_positive_sync_kickstart_check_os'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6669
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_repository.py -k test_positive_sync_kickstart_check_os --external-logging
Test Result : ========= 4 passed, 165 deselected, 250 warnings in 1021.33s (0:17:01) =========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 24, 2024
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_repositories.py -k 'test_positive_disable_rh_repo_with_basearch'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6672
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_repositories.py -k test_positive_disable_rh_repo_with_basearch --external-logging
Test Result : =========== 1 passed, 4 deselected, 13 warnings in 803.11s (0:13:23) ===========

Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In master this was changed by #14673. But I can't see the changes in 6.15.z.
Can you raise this against 6.15.z and CP back to 6.14.z to keep the branches consistent?

@vijaysawant
Copy link
Contributor Author

In master this was changed by #14673. But I can't see the changes in 6.15.z. Can you raise this against 6.15.z and CP back to 6.14.z to keep the branches consistent?

This branch is locally checkout against upstream/6.14.z and I am thinking to open separate PR for 6.15.z

@vijaysawant vijaysawant changed the title fix keyError: 'rhel8 + _bos' from api>tests_repository.py 6.14.z-fix keyError: 'rhel8 + _bos' from api>tests_repository.py Apr 24, 2024
@vijaysawant
Copy link
Contributor Author

In master this was changed by #14673. But I can't see the changes in 6.15.z. Can you raise this against 6.15.z and CP back to 6.14.z to keep the branches consistent?

This branch is locally checkout against upstream/6.14.z and I am thinking to open separate PR for 6.15.z

Here it is PR for 6.15.z #14878

@vsedmik vsedmik merged commit 69c0bb1 into SatelliteQE:6.14.z Apr 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants