Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Fix omitting credentials when CLI has already been instantiated #14880

Merged
merged 1 commit into from
Apr 25, 2024
Merged

[6.15.z] Fix omitting credentials when CLI has already been instantiated #14880

merged 1 commit into from
Apr 25, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14449

Problem Statement

Omitting credentials doesn't work when CLI has already been instantiated

Solution

If it's been instantiated, set its omitting attribute to True for all the classes

@lhellebr @web-flow
Fix omitting credentials when CLI has already been instantiated (#14449)
b6c2aba 
* Fix omitting credentials when CLI has already been instantiated

* Rework based on comments

* Set to False after yield

(cherry picked from commit 845ef03)
@Satellite-QE Satellite-QE requested a review from a team as a code owner April 25, 2024 07:59
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Apr 25, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py::test_positive_negotiate_manual_with_autonegotiation_disabled tests/foreman/destructive/test_ldap_authentication.py::test_positive_autonegotiate

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6682
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py::test_positive_negotiate_manual_with_autonegotiation_disabled tests/foreman/destructive/test_ldap_authentication.py::test_positive_autonegotiate --external-logging
Test Result : ================ 4 passed, 1069 warnings in 11131.62s (3:05:31) ================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 25, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit f6e7f86 into 6.15.z Apr 25, 2024
16 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.15.z-845ef03f9e55d75bd751f2f3646c66b2c33b9e00 branch April 25, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@lhellebr lhellebr

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @Gauravtalreja1 @lhellebr