Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] added scap constant #14922

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14921

Problem Statement

with recent changes in oscap related fixtures, the lack of the rhel9 variant in constants causes key error

Solution

added an item into constants

Related Issues

(cherry picked from commit 4c00785)
@Satellite-QE Satellite-QE requested a review from a team as a code owner April 30, 2024 12:22
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Apr 30, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_oscap.py -k test_postive_create_scap_policy_with_valid_name[cjk]

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Apr 30, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6749
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_oscap.py -k  test_postive_create_scap_policy_with_valid_name[cjk] --external-logging
Test Result : =========== 70 deselected, 78 warnings, 1 error in 673.43s (0:11:13) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 30, 2024
@Gauravtalreja1
Copy link
Collaborator

@pondrejk PRT failing with other KeyError now, could you check and add that to constants as well?

        scap_profile_id = [
            profile['id']
            for profile in scap_info.scap_content_profiles
>           if OSCAP_PROFILE[settings.oscap.profile] in profile['title']
        ][0]
E       KeyError: 'security8'

pytest_fixtures/component/oscap.py:42: KeyError

@pondrejk pondrejk marked this pull request as draft May 7, 2024 08:20
@pondrejk
Copy link
Contributor

pondrejk commented May 7, 2024

hello, turns out #14716 should have been cherrypicked, with that in, this should pass too, moving to draft meanwhile

@pondrejk pondrejk marked this pull request as ready for review May 7, 2024 09:26
@pondrejk
Copy link
Contributor

pondrejk commented May 7, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_oscap.py -k test_postive_create_scap_policy_with_valid_name[cjk]

@pondrejk
Copy link
Contributor

pondrejk commented May 7, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_oscap.py -k test_postive_create_scap_policy_with_valid_name[cjk]

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6819
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_oscap.py -k test_postive_create_scap_policy_with_valid_name[cjk] --external-logging
Test Result : =========== 70 deselected, 78 warnings, 1 error in 784.11s (0:13:04) ===========

@Satellite-QE Satellite-QE merged commit 9e8695d into 6.15.z May 7, 2024
9 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.15.z-4c00785383e3a0e2c71de44ce9411b41a6956f39 branch May 7, 2024 11:14
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6823
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_oscap.py -k test_postive_create_scap_policy_with_valid_name[cjk] --external-logging
Test Result : ========== 1 passed, 70 deselected, 79 warnings in 741.88s (0:12:21) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants