Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

host: inherit LCE & CV with nested hostgroup #14925

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

host: inherit LCE & CV with nested hostgroup #14925

wants to merge 1 commit into from

Conversation

pnovotny
Copy link
Contributor

Problem Statement

Nested inheritance of hostgroup is not honored for LCE & CV.
(https://bugzilla.redhat.com/2266432)

Solution

Include a nested hostgroup in existing test
tests/foreman/api/test_host.py::test_positive_create_inherit_lce_cv.

@pnovotny pnovotny self-assigned this Apr 30, 2024
@pnovotny
Copy link
Contributor Author

This PR is currently waiting for PRT verification once https://bugzilla.redhat.com/2266432 is ON_QA (currently ON_DEV).

@pnovotny pnovotny added No-CherryPick PR doesnt need CherryPick to previous branches Do Not Merge labels Apr 30, 2024
@adamruzicka
Copy link

BZ2266432 is ON_QA now

@pnovotny pnovotny force-pushed the inherit-lce-cv-nested-group branch from c546a33 to c0aeca1 Compare May 22, 2024 10:37
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_host.py -k test_positive_create_inherit_lce_cv

@pnovotny pnovotny added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 and removed No-CherryPick PR doesnt need CherryPick to previous branches Do Not Merge labels May 22, 2024
@pnovotny pnovotny marked this pull request as ready for review May 22, 2024 10:40
@pnovotny pnovotny requested a review from a team as a code owner May 22, 2024 10:40
@pnovotny pnovotny requested review from lhellebr and pondrejk May 22, 2024 10:41
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7060
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_host.py -k test_positive_create_inherit_lce_cv --external-logging
Test Result : ========== 1 failed, 62 deselected, 71 warnings in 651.50s (0:10:51) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 22, 2024
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_host.py -k test_positive_create_inherit_lce_cv

@pnovotny pnovotny force-pushed the inherit-lce-cv-nested-group branch from c0aeca1 to 88a5d3f Compare June 10, 2024 10:21
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7332
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_host.py -k test_positive_create_inherit_lce_cv --external-logging
Test Result : ========== 1 failed, 62 deselected, 71 warnings in 790.46s (0:13:10) ===========

@pnovotny
host: inherit LCE & CV with nested hostgroup
49c801f 
Bugzilla: https://bugzilla.redhat.com/2266432

Expanding test tests/foreman/api/test_host.py::test_positive_create_inherit_lce_cv
to include also a nested hostgroup.
@pnovotny pnovotny force-pushed the inherit-lce-cv-nested-group branch from 88a5d3f to 49c801f Compare July 12, 2024 17:24
@pnovotny pnovotny requested a review from a team as a code owner July 12, 2024 17:24
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_host.py -k test_positive_create_inherit_lce_cv

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7734
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_host.py -k test_positive_create_inherit_lce_cv --external-logging
Test Result : ========== 1 failed, 62 deselected, 71 warnings in 640.28s (0:10:40) ===========

@jameerpathan111
Copy link
Contributor

@pnovotny I'm converting this pr to draft for now, please mark it ready for review once you're done with changes/addressing the comments.

@jameerpathan111 jameerpathan111 marked this pull request as draft August 20, 2024 14:35
@jyejare jyejare added the 6.16.z Introduced in or relating directly to Satellite 6.16 label Aug 22, 2024
@lhellebr
Copy link
Contributor

lhellebr commented Sep 4, 2024

@pnovotny Are you planning to continue this work or should this PR be closed?

@pnovotny
Copy link
Contributor Author

pnovotny commented Sep 4, 2024

@pnovotny Are you planning to continue this work or should this PR be closed?

I know it has been on the back burner for some time, but I plan to continue to work on this. Please do not close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhellebr lhellebr Awaiting requested review from lhellebr

@pondrejk pondrejk Awaiting requested review from pondrejk

Assignees

@pnovotny pnovotny

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pnovotny @adamruzicka @Satellite-QE @jameerpathan111 @lhellebr @jyejare