Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests/upgrades/test_satellite_maintain.py and list-versions #14970

Merged
merged 1 commit into from
May 28, 2024
Merged

Remove tests/upgrades/test_satellite_maintain.py and list-versions #14970

merged 1 commit into from
May 28, 2024

Conversation

Griffin-Sullivan
Copy link
Contributor

Problem Statement

The list-versions command will no longer be needed for z-stream updates.

Solution

Remove tests relying on the list-versions subcommand for satellite-maintain update

Related Issues

@Griffin-Sullivan Griffin-Sullivan added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels May 6, 2024
@Griffin-Sullivan Griffin-Sullivan requested a review from a team as a code owner May 6, 2024 13:04
@Griffin-Sullivan Griffin-Sullivan marked this pull request as draft May 6, 2024 13:05
@Griffin-Sullivan Griffin-Sullivan mentioned this pull request May 6, 2024
Merged
@rmynar
Copy link
Contributor

rmynar commented May 6, 2024

Shouldn't we modify these tests for y-stream upgrade instead of completely removing?

@Griffin-Sullivan Griffin-Sullivan mentioned this pull request May 15, 2024
Merged
@Griffin-Sullivan Griffin-Sullivan changed the title Remove tests/upgrades/test_satellite_maintain.py Remove tests/upgrades/test_satellite_maintain.py and list-versions May 23, 2024
@Griffin-Sullivan Griffin-Sullivan mentioned this pull request May 23, 2024
Merged
@Griffin-Sullivan
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/maintain/test_upgrade.py::test_positive_self_update_maintain_package[satellite]
theforeman:
    foreman_maintain: 841

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7098
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/maintain/test_upgrade.py::test_positive_self_update_maintain_package[satellite] --external-logging
Test Result : ================= 1 failed, 13 warnings in 3018.03s (0:50:18) ==================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 23, 2024
@Griffin-Sullivan
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/maintain/test_upgrade.py::test_positive_self_update_maintain_package[satellite]
theforeman:
    foreman_maintain: 841

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7111
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/maintain/test_upgrade.py::test_positive_self_update_maintain_package[satellite] --external-logging
Test Result : ================= 1 failed, 13 warnings in 2981.85s (0:49:41) ==================

@Griffin-Sullivan
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/maintain/test_upgrade.py::test_positive_self_update_maintain_package[satellite]
theforeman:
    foreman_maintain: 841

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7137
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/maintain/test_upgrade.py::test_positive_self_update_maintain_package[satellite] --external-logging
Test Result : ================= 1 passed, 13 warnings in 3245.47s (0:54:05) ==================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 28, 2024
@Griffin-Sullivan Griffin-Sullivan marked this pull request as ready for review May 28, 2024 14:19
@Griffin-Sullivan Griffin-Sullivan requested a review from a team as a code owner May 28, 2024 14:19
@Griffin-Sullivan
Copy link
Contributor Author

dn't we modify these tests for y-stream upgrade instead of completely removing?

@rmynar since we are also removing list-versions there's no point to be running those tests. Besides that point, we have plenty of upgrade testing that covers the setup of upgrades, so having these tests was redundant IMO.

@JacobCallahan JacobCallahan merged commit b12bfbc into SatelliteQE:master May 28, 2024
12 checks passed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@Griffin-Sullivan @jyejare
Remove tests/upgrades/test_satellite_maintain.py and list-versions (S…
c4d1106 
…atelliteQE#14970)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@JacobCallahan JacobCallahan JacobCallahan approved these changes

Assignees

@Griffin-Sullivan Griffin-Sullivan

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Griffin-Sullivan @rmynar @Satellite-QE @JacobCallahan @ColeHiggins2